test: add integration tests for flows with map steps #222

jumski · 2025-09-19T20:35:12Z

Introduce new tests covering root map, dependent map, and empty array map scenarios.
Verify correct execution, task creation, and output aggregation for various flow configurations.

changeset-bot · 2025-09-19T20:35:15Z

⚠️ No Changeset found

Latest commit: b89cc1d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

coderabbitai · 2025-09-19T20:35:19Z

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches

🧪 Generate unit tests

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch 09-19-chore-add-integration-tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

jumski · 2025-09-19T20:35:44Z

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

merge:queue - adds this PR to the back of the merge queue
hotfix:queue - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

nx-cloud · 2025-09-19T20:40:02Z

🤖 Nx Cloud AI Fix Eligible

An automatically generated fix could have helped fix failing tasks for this run, but Self-healing CI is disabled for this workspace. Visit workspace settings to enable it and get automatic fixes in future runs.

_{To disable these notifications, a workspace admin can disable them in workspace settings.}

View your CI Pipeline Execution ↗ for commit b89cc1d

Command	Status	Duration	Result
`nx affected -t lint typecheck test --parallel -...`	❌ Failed	6m 33s	View ↗

☁️ Nx Cloud last updated this comment at 2025-10-06 15:33:53 UTC

graphite-app · 2025-09-20T23:00:38Z

pkgs/edge-worker/tests/integration/flow/startDelayFlow.test.ts

+      const firstAttemptTasks = await sql`
+        SELECT status, attempts_count, error_message FROM pgflow.step_tasks
        WHERE run_id = ${flowRun.run_id} AND step_slug = 'retryStep';
      `;
+      const firstAttemptTask = firstAttemptTasks[0];


The query result is stored in firstAttemptTasks array, but then the code immediately accesses firstAttemptTasks[0] without checking if the array contains any elements. This could lead to accessing properties on undefined if the query returns no results. Consider adding a null check before accessing the first element:

const firstAttemptTasks = await sql`...`; if (firstAttemptTasks.length === 0) { // Handle empty result case return; } const firstAttemptTask = firstAttemptTasks[0];

Suggested change

const firstAttemptTasks = await sql`

SELECT status, attempts_count, error_message FROM pgflow.step_tasks

WHERE run_id = ${flowRun.run_id} AND step_slug = 'retryStep';

`;

const firstAttemptTask = firstAttemptTasks[0];

const firstAttemptTasks = await sql`

SELECT status, attempts_count, error_message FROM pgflow.step_tasks

WHERE run_id = ${flowRun.run_id} AND step_slug = 'retryStep';

`;

if (firstAttemptTasks.length === 0) {

throw new Error('No tasks found for retryStep');

}

const firstAttemptTask = firstAttemptTasks[0];

Spotted by Diamond

Is this helpful? React 👍 or 👎 to let us know.

github-actions · 2025-10-05T19:29:07Z

🔍 Preview Deployment: Website

✅ Deployment successful!

🔗 Preview URL: https://pr-222.pgflow.pages.dev

📝 Details:

Branch: 09-19-chore-add-integration-tests
Commit: 195faf4808566f1ab763dd142d0e7673c2c8fd17
View Logs

_Last updated: _

github-actions · 2025-10-05T19:31:01Z

🔍 Preview Deployment: Playground

✅ Deployment successful!

🔗 Preview URL: https://pr-222--pgflow-demo.netlify.app

📝 Details:

Branch: 09-19-chore-add-integration-tests
Commit: 195faf4808566f1ab763dd142d0e7673c2c8fd17
View Logs

_Last updated: _

Introduce new tests covering root map, dependent map, and empty array map scenarios. Verify correct execution, task creation, and output aggregation for various flow configurations.

graphite-app · 2025-10-07T08:28:24Z

Merge activity

Oct 7, 8:28 AM UTC: jumski added this pull request to the Graphite merge queue.
Oct 7, 8:29 AM UTC: CI is running for this pull request on a draft pull request (#232) due to your merge queue CI optimization settings.
Oct 7, 8:29 AM UTC: Merged by the Graphite merge queue via draft PR: #232.

Introduce new tests covering root map, dependent map, and empty array map scenarios. Verify correct execution, task creation, and output aggregation for various flow configurations.

This was referenced Sep 19, 2025

feat: add map and array steps for parallel processing #207

Closed

feat: add map step type in sql #208

Closed

jumski changed the title ~~test: add integration tests for flow mapping and array handling~~ test: add integration tests for flows with map steps Sep 19, 2025

jumski mentioned this pull request Sep 19, 2025

feat: add root map step support #209

Closed

jumski marked this pull request as ready for review September 19, 2025 20:35

jumski mentioned this pull request Sep 19, 2025

feat: add task_index attribute to step_task_record and start_tasks function #221

Closed

jumski force-pushed the 09-19-chore-add-integration-tests branch 7 times, most recently from b63837a to ece6b73 Compare September 20, 2025 22:58

graphite-app bot reviewed Sep 20, 2025

View reviewed changes

jumski temporarily deployed to preview September 20, 2025 23:17 — with GitHub Actions Inactive

jumski force-pushed the 09-19-add-task-index-in-start-tasks branch from 5543ded to c2a2e38 Compare October 5, 2025 18:59

jumski force-pushed the 09-19-chore-add-integration-tests branch from ece6b73 to 583047f Compare October 5, 2025 18:59

jumski mentioned this pull request Oct 5, 2025

docs: improve documentation and READMEs to explain map/array steps #228

Closed

jumski force-pushed the 09-19-chore-add-integration-tests branch from 583047f to eed4e5e Compare October 5, 2025 19:20

jumski force-pushed the 09-19-add-task-index-in-start-tasks branch from c2a2e38 to 2e8084f Compare October 5, 2025 19:20

jumski temporarily deployed to preview October 5, 2025 19:28 — with GitHub Actions Inactive

jumski mentioned this pull request Oct 6, 2025

fix: remove temp migrations and prepare stack to be merged #230

Closed

test: add integration tests for flow mapping and array handling

b89cc1d

Introduce new tests covering root map, dependent map, and empty array map scenarios. Verify correct execution, task creation, and output aggregation for various flow configurations.

jumski force-pushed the 09-19-chore-add-integration-tests branch from eed4e5e to b89cc1d Compare October 6, 2025 15:25

jumski force-pushed the 09-19-add-task-index-in-start-tasks branch from 2e8084f to 85630ea Compare October 6, 2025 15:25

jumski mentioned this pull request Oct 6, 2025

fix: typecheck tests using strict tsc mode #231

Closed

graphite-app bot closed this Oct 7, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

test: add integration tests for flows with map steps #222

test: add integration tests for flows with map steps #222

Uh oh!

jumski commented Sep 19, 2025

Uh oh!

changeset-bot bot commented Sep 19, 2025 •

edited

Loading

Uh oh!

coderabbitai bot commented Sep 19, 2025

Review skipped

Uh oh!

jumski commented Sep 19, 2025 •

edited

Loading

Uh oh!

nx-cloud bot commented Sep 19, 2025 •

edited

Loading

Uh oh!

graphite-app bot Sep 20, 2025

Uh oh!

github-actions bot commented Oct 5, 2025

Uh oh!

github-actions bot commented Oct 5, 2025

Uh oh!

graphite-app bot commented Oct 7, 2025 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

test: add integration tests for flows with map steps #222

test: add integration tests for flows with map steps #222

Uh oh!

Conversation

jumski commented Sep 19, 2025

Uh oh!

changeset-bot bot commented Sep 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

coderabbitai bot commented Sep 19, 2025

Review skipped

Uh oh!

jumski commented Sep 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to use the Graphite Merge Queue

Uh oh!

nx-cloud bot commented Sep 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🤖 Nx Cloud AI Fix Eligible

Uh oh!

graphite-app bot Sep 20, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Oct 5, 2025

🔍 Preview Deployment: Website

Uh oh!

github-actions bot commented Oct 5, 2025

🔍 Preview Deployment: Playground

Uh oh!

graphite-app bot commented Oct 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

changeset-bot bot commented Sep 19, 2025 •

edited

Loading

jumski commented Sep 19, 2025 •

edited

Loading

nx-cloud bot commented Sep 19, 2025 •

edited

Loading

graphite-app bot commented Oct 7, 2025 •

edited

Loading