Add missing descriptors for SmallFloatType and EnumType
#656
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
janedbal
commented
Apr 24, 2025
janedbal
commented
- Implement an EnumType for MySQL/MariaDB doctrine/dbal#6536 (since dbal 4.2)
- Add SmallFloat type doctrine/dbal#6471 (since dbal 4.1)
janedbal
force-pushed
the
smallfloat-descriptor
branch
from
2082cc3 to
2e8b2b6
Compare
janedbal
commented
Apr 24, 2025
| path: src/Type/Doctrine/Descriptors/SmallFloatType.php | ||
|
|
||
| - | ||
| message: '#^Class Doctrine\\DBAL\\Types\\EnumType not found\.$#' |
There was a problem hiding this comment.
At first, I tried adding new doctrine versions to composer.json, but it would require bigger effort to adjust this repo to support those everywhere, so I just referenced those not-yet-existing classes.
ondrejmirtes
requested changes
Apr 24, 2025
|
|
||
| namespace PHPStan\Type\Doctrine\Descriptors; | ||
|
|
||
| class SmallFloatType extends FloatType |
| use PHPStan\Type\StringType; | ||
| use PHPStan\Type\Type; | ||
|
|
||
| class EnumType implements DoctrineTypeDescriptor |
There was a problem hiding this comment.
Am I wrong or without this type the data is considered as mixed ?
Now with this, it will report error foo be 'A'|'B' but is string on level 8 because the values option is not considered in the following code
#[ORM\Column(name: 'foo', type: Types::ENUM, options: ['values' => ['A', 'B'])]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.