-
Notifications
You must be signed in to change notification settings - Fork 103
Add missing descriptors for SmallFloatType
and EnumType
#656
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 2.0.x
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,33 @@ | ||
parameters: | ||
ignoreErrors: | ||
- | ||
message: '#^Class Doctrine\\DBAL\\Types\\EnumType not found\.$#' | ||
identifier: class.notFound | ||
count: 1 | ||
path: src/Type/Doctrine/Descriptors/EnumType.php | ||
|
||
- | ||
message: '#^Method PHPStan\\Type\\Doctrine\\Descriptors\\EnumType\:\:getType\(\) should return class\-string\<Doctrine\\DBAL\\Types\\Type\> but returns string\.$#' | ||
identifier: return.type | ||
count: 1 | ||
path: src/Type/Doctrine/Descriptors/EnumType.php | ||
|
||
- | ||
message: '#^Class Doctrine\\DBAL\\Types\\SmallFloatType not found\.$#' | ||
identifier: class.notFound | ||
count: 1 | ||
path: src/Type/Doctrine/Descriptors/SmallFloatType.php | ||
|
||
- | ||
message: '#^Method PHPStan\\Type\\Doctrine\\Descriptors\\SmallFloatType\:\:getType\(\) should return class\-string\<Doctrine\\DBAL\\Types\\Type\> but returns string\.$#' | ||
identifier: return.type | ||
count: 1 | ||
path: src/Type/Doctrine/Descriptors/SmallFloatType.php | ||
|
||
- | ||
message: '#^Class Doctrine\\DBAL\\Types\\EnumType not found\.$#' | ||
identifier: class.notFound | ||
count: 1 | ||
path: src/Type/Doctrine/Query/QueryResultTypeWalker.php | ||
|
||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,31 @@ | ||
<?php declare(strict_types = 1); | ||
|
||
namespace PHPStan\Type\Doctrine\Descriptors; | ||
|
||
use PHPStan\Type\StringType; | ||
use PHPStan\Type\Type; | ||
|
||
class EnumType implements DoctrineTypeDescriptor | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Am I wrong or without this type the data is considered as mixed ? Now with this, it will report error
|
||
{ | ||
|
||
public function getType(): string | ||
{ | ||
return \Doctrine\DBAL\Types\EnumType::class; | ||
} | ||
|
||
public function getWritableToPropertyType(): Type | ||
{ | ||
return new StringType(); | ||
} | ||
|
||
public function getWritableToDatabaseType(): Type | ||
{ | ||
return new StringType(); | ||
} | ||
|
||
public function getDatabaseInternalType(): Type | ||
{ | ||
return new StringType(); | ||
} | ||
|
||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
<?php declare(strict_types = 1); | ||
|
||
namespace PHPStan\Type\Doctrine\Descriptors; | ||
|
||
class SmallFloatType extends FloatType | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. No inheritance please |
||
{ | ||
|
||
public function getType(): string | ||
{ | ||
return \Doctrine\DBAL\Types\SmallFloatType::class; | ||
} | ||
|
||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At first, I tried adding new doctrine versions to composer.json, but it would require bigger effort to adjust this repo to support those everywhere, so I just referenced those not-yet-existing classes.