Make k8s-metrics-collector chart compatible with readOnlyRootFilesystem: true#47
Open
ghost wants to merge 4 commits intopileus-cloud:mainfrom
Open
Make k8s-metrics-collector chart compatible with readOnlyRootFilesystem: true#47ghost wants to merge 4 commits intopileus-cloud:mainfrom
readOnlyRootFilesystem: true#47ghost wants to merge 4 commits intopileus-cloud:mainfrom
Conversation
ghost
self-requested a review
as a
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have security requirements on our Kubernetes cluster, one of which is that all pods have a readOnlyRootFilesystem in their security policy (and the commented example in the chart already has).
However there are a number of bits of the app which seem to write to the root filesystem; the logging (to /var/log/agent.log) and the app data directory which also contains read only data.
The approach I've taken is pretty hacky but does work. It might be better to alter the app itself to use /tmp for writing any data and stop logging to the filesystem as well as stdout.