Skip to content

Make k8s-metrics-collector chart compatible with readOnlyRootFilesystem: true #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ghost wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Make k8s-metrics-collector chart compatible with readOnlyRootFilesystem: true #47

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4dd53eb
Set up emptydir volume for appdata
Dec 18, 2024
dd4119b
Also mount /var/log
Dec 18, 2024
93ec24c
Also mount /var/log for cronjob
Dec 18, 2024
29126cb
There is such thing as too much hackery
Dec 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion helm-chart-sources/k8s-metrics-collector/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ appVersion: 0.3.20
description: A Helm chart for Kubernetes
name: k8s-metrics-collector
type: application
version: 0.1.21
version: 0.1.22
dependencies:
- condition: kubePrometheusStack.enabled
name: kube-prometheus-stack
Expand Down
12 changes: 11 additions & 1 deletion helm-chart-sources/k8s-metrics-collector/templates/cronjob.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,8 @@ spec:
value: {{ .Values.workload }}
- name: APP_VERSION
value: {{ .Values.image.tag | default .Chart.AppVersion }}
- name: APP_DATA_DIR
value: /tmp/data
{{- if .Values.kubePrometheusStack.enabled }}
- name: PROMETHEUS_URL
value: http://{{ index .Values "kube-prometheus-stack" "fullnameOverride" }}-prometheus:9090
Expand Down Expand Up @@ -97,7 +99,13 @@ spec:
{{- end }}
{{- end }}
{{- end }}

- mountPath: /tmp
name: appdata
subPath: tmp
- mountPath: /var/log
name: appdata
subPath: log
command: ["/bin/sh", "-c", "cp -r /usr/src/app/src/agent/data /tmp && /usr/src/app/entry.sh"]
resources:
{{- toYaml .Values.resources | nindent 16 }}
volumes:
Expand All @@ -108,6 +116,8 @@ spec:
name: {{ include "k8s-metrics-collector.fullname" . }}
{{- end }}
{{- end }}
- emptyDir: {}
name: appdata

{{- with .Values.nodeSelector }}
nodeSelector:
Expand Down
11 changes: 11 additions & 0 deletions helm-chart-sources/k8s-metrics-collector/templates/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,8 @@ spec:
value: {{ .Values.workload }}
- name: APP_VERSION
value: {{ .Values.image.tag | default .Chart.AppVersion }}
- name: APP_DATA_DIR
value: /tmp/data
{{- if .Values.kubePrometheusStack.enabled }}
- name: PROMETHEUS_URL
value: http://{{ index .Values "kube-prometheus-stack" "fullnameOverride" }}-prometheus:9090
Expand Down Expand Up @@ -95,6 +97,13 @@ spec:
{{- end }}
{{- end }}
{{- end }}
- mountPath: /tmp
name: appdata
subPath: tmp
- mountPath: /var/log
name: appdata
subPath: log
command: ["/bin/sh", "-c", "cp -r /usr/src/app/src/agent/data /tmp && /usr/src/app/entry.sh"]
resources:
{{- toYaml .Values.resources | nindent 12 }}
volumes:
Expand All @@ -105,6 +114,8 @@ spec:
name: {{ include "k8s-metrics-collector.fullname" . }}
{{- end }}
{{- end }}
- emptyDir: {}
name: appdata
{{- with .Values.nodeSelector }}
nodeSelector:
{{- toYaml . | nindent 8 }}
Expand Down
1 change: 1 addition & 0 deletions helm-chart-sources/k8s-metrics-collector/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,6 +179,7 @@ podSecurityContext: {}
# fsGroup: 2000

securityContext: {}
# allowPrivilegeEscalation: false
# capabilities:
# drop:
# - ALL
Expand Down