pkp/pkp-lib#10263 Fix submission mapper crash when review assignments are null #2103
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hafsa-Naeem
force-pushed
the
i10263-stable_3_5_0-follow-up
branch
3 times, most recently
from
f14b59d to
83bc2c8
Compare
Hafsa-Naeem
force-pushed
the
i10263-stable_3_5_0-follow-up
branch
from
83bc2c8 to
9bab057
Compare
Hafsa-Naeem
changed the title
Hafsa-Naeem
force-pushed
the
i10263-stable_3_5_0-follow-up
branch
from
ef8af99 to
e88f603
Compare
asmecher
reviewed
Aug 27, 2025
| @@ -76,14 +76,18 @@ protected function mapByProperties(array $props, Submission $submission, bool|Co | |||
|
|
|||
| $reviewRounds = $this->getGroupedReviewRoundsFromSubmission($submission); | |||
| $currentReviewRound = $reviewRounds->flatten()->sort()->last(); /** @var ReviewRound|null $currentReviewRound */ | |||
| // normalizing possibly null collections | |||
There was a problem hiding this comment.
@Hafsa-Naeem, are these changes due to a case you encountered where $stageAssignments or $reviewAssignments is null? Or is it just the potential for that situation based e.g. on the typehint in the class?
There was a problem hiding this comment.
@asmecher Yes, this was from a real case in OMP. After allowing managers/editors to access submissions they're not assigned to, the reviewAssignments and stageAssignments were null and caused a fatal error in mapByProperties().
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for #10263