Skip to content

pkp/pkp-lib#10263 Fix submission mapper crash when review assignments are null #2103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: stable-3_5_0
Choose a base branch
from
Open

pkp/pkp-lib#10263 Fix submission mapper crash when review assignments are null #2103

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9bab057
pkp/pkp-lib#10263 Fix submission mapper crash when review assignments…
Hafsa-Naeem Aug 27, 2025
e88f603
pkp/pkp-lib#10263 Submodule update ##Hafsa-Naeem/i10263-stable_3_5_0-…
Hafsa-Naeem Aug 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions classes/submission/maps/Schema.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,14 +76,18 @@ protected function mapByProperties(array $props, Submission $submission, bool|Co

$reviewRounds = $this->getGroupedReviewRoundsFromSubmission($submission);
$currentReviewRound = $reviewRounds->flatten()->sort()->last(); /** @var ReviewRound|null $currentReviewRound */
// normalizing possibly null collections
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Hafsa-Naeem, are these changes due to a case you encountered where $stageAssignments or $reviewAssignments is null? Or is it just the potential for that situation based e.g. on the typehint in the class?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@asmecher Yes, this was from a real case in OMP. After allowing managers/editors to access submissions they're not assigned to, the reviewAssignments and stageAssignments were null and caused a fatal error in mapByProperties().

$stageAssignments = $this->stageAssignments ?? collect();
$reviewAssignments = $this->reviewAssignments ?? collect();

foreach ($props as $prop) {
switch ($prop) {
case 'recommendationsIn':
$output[$prop] = $currentReviewRound ? $this->areRecommendationsIn($currentReviewRound, $this->stageAssignments) : null;
$output[$prop] = $currentReviewRound ? $this->areRecommendationsIn($currentReviewRound, $stageAssignments) : null;
break;
case 'reviewersNotAssigned':
$output[$prop] = $currentReviewRound && $this->reviewAssignments->count() >= intval($this->context->getData('numReviewersPerSubmission'));
$required = $this->context->getNumReviewsPerSubmission();
$output[$prop] = $currentReviewRound && $reviewAssignments->count() < $required;
break;
case 'reviewRounds':
$output[$prop] = $this->getPropertyReviewRounds($reviewRounds->flatten());
Expand Down
2 changes: 1 addition & 1 deletion lib/pkp
Open in desktop
Submodule pkp updated 4 files
+2 −0 classes/mail/Mailer.php
+3 −3 classes/security/authorization/PublicationWritePolicy.php
+7 −6 classes/submission/Repository.php
+34 −31 classes/submission/maps/Schema.php