Skip to content

fix(typescript): normalize hosted venue names before allowlist checks#1794

Open
Solaris-star wants to merge 1 commit into
pmxt-dev:mainfrom
Solaris-star:fix/typescript-hosted-venue-case
Open

fix(typescript): normalize hosted venue names before allowlist checks#1794
Solaris-star wants to merge 1 commit into
pmxt-dev:mainfrom
Solaris-star:fix/typescript-hosted-venue-case

Conversation

@Solaris-star

Copy link
Copy Markdown

Summary

  • Normalize exchangeName before checking the hosted trading venue allowlist.
  • Keep the original venue name in the unsupported venue error for diagnostics.
  • Add regression coverage for supported venue names with mixed casing.

Issue

Closes #1717

Testing

  • git diff --check passed.
  • Focused Jest test was attempted with the repository Jest config, but the checkout does not contain the ignored generated TypeScript client under sdks/typescript/generated/.
  • The repository OpenAPI generation command was attempted, but this environment has no Java Runtime, so the generated client could not be produced locally.

Signed-off-by: Solaris-star <820622658@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SDK drift: ensureHostedTradingSupported venue-allowlist check is case-sensitive in TypeScript but case-normalized in Python's _client_venue

1 participant