Skip to content

fix(typescript): normalize hosted venue names before allowlist checks #1794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Solaris-star wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(typescript): normalize hosted venue names before allowlist checks #1794

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sdks/typescript/pmxt/hosted-routing.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ export interface HostedClientLike {
*/
export function ensureHostedTradingSupported(client: HostedClientLike): void {
if (!client.pmxtApiKey) return;
if (!HOSTED_TRADING_VENUES.has(client.exchangeName)) {
if (!HOSTED_TRADING_VENUES.has(client.exchangeName.toLowerCase())) {
throw new NotSupported(
`Hosted trading is only supported for Polymarket, Opinion, and Limitless; ${client.exchangeName} is not supported with pmxtApiKey.`,
);
Expand Down
11 changes: 11 additions & 0 deletions sdks/typescript/tests/hosted-dispatch.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ jest.mock("../pmxt/hosted-typed-data", () => ({

import { Polymarket } from "../pmxt/client";
import {
ensureHostedTradingSupported,
HOSTED_TRADING_BASE_URL,
} from "../pmxt/hosted-routing";
import { NotSupported } from "../pmxt/errors";
Expand Down Expand Up @@ -162,6 +163,16 @@ describe("hosted read methods raise MissingWalletAddress locally", () => {
// --------------------------------------------------------------------------

describe("hosted NotSupported", () => {
it.each(["Polymarket", "OPINION", "LiMiTlEsS"])(
"accepts supported venue %s regardless of casing",
(exchangeName) => {
expect(() => ensureHostedTradingSupported({
pmxtApiKey: PMXT_API_KEY,
exchangeName,
})).not.toThrow();
},
);

it("fetchClosedOrders raises NotSupported without touching network", async () => {
const spy = installFetchSpy(() => jsonResponse({}));
const api = makePolymarket();
Expand Down