-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bundle Quarto CLI with Positron #3705
Comments
This change bundles the Quarto CLI and all of its requisite tooling (deno, typst, etc.) with Positron, replacing the former Pandoc-only approach. Quarto is currently version-pinned at 1.5.55. The Quarto bundle is stored in the `quarto` subdirectory of the app root. Addresses #3705. > [!IMPORTANT] > This change alone is not sufficient to allow the Quarto extension to discover the copy of Quarto bundled in Positron; the Quarto extension's search path is not configurable, so a separate change will need to be made to the Quarto extension to include the Positron app directory in the search path. I'll make that change once this one has landed successfully. ### QA Notes - This change needs to be tested on all 3 platforms. - The Quarto extension _does_ look on the `PATH` for Quarto, so if you're feeling brave you can cause it to use this bundled version of Quarto by putting it on your `PATH`. - This change uses a different version of Pandoc and puts Pandoc in a new location. Make sure that `RSTUDIO_PANDOC` points to a folder that contains the pandoc executable, and that `rmarkdown::find_pandoc()` and the "Render R Markdown" command are able to use the new Pandoc. - Both the Quarto extension and R Markdown package will find Quarto/Pandoc on the `PATH`, so to ensure you're testing against the embedded copy of Quarto and Pandoc in Positron, make sure to remove any other installations of Quarto and Pandoc on your `PATH` (or temporarily modify your `PATH` so they aren't discovered) - It is expected that this change will dramatically increase the size of the installers.
We're bundling Quarto as of #4212, but to complete this story we also need a version of the Quarto extension that can find the bundle. quarto-dev/quarto#503 contains the needed changes. |
Looks like quarto-dev/quarto#503 just was merged in by JJ. Any chance the built-in Quarto extension could get bumped? 😄 |
Yes, we'll bundle 1.114.0 of the extension when it becomes available (JJ will need to do the release first). |
Should be ready to test now, note that there's still a problem with the Quarto extension not adding the Quarto path to the |
Anyone have thoughts on what can be tested prior to quarto-dev/quarto#517 being completed? It seems to me like we might need to wait on that to really test that bundling works. Without it, I am assuming that one would not truly be using the bundled extension. |
As I just posted in the quarto issue quarto-dev/quarto#517 (comment) I just tried with the latest build of Positron (2024.08.0-77 on Windows and it doesn't find Quarto.
|
This should work now unless pyenv is active. As noted in quarto-dev/quarto#517 (comment), pyenv is removing Quarto from the QA, can we close this one (assuming the non-pyenv case works okay)? I have opened #4561 to track the pyenv case. |
Verified Fixed
Test scenario(s)Non pyenv runs work fine! Link(s) to TestRail test cases run or created: |
The Quarto Extension does not come with a Quarto CLI, so to make it simpler for customers to use Quarto with Positron out of the box, we should also look to bundle the Quarto CLI.
We currently bundle the Pandoc CLI separately, this would need to be coordinated with the inclusion of Quarto instead.
The text was updated successfully, but these errors were encountered: