Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove bats tests #2558

Merged
merged 2 commits into from
Jan 28, 2025
Merged

Remove bats tests #2558

merged 2 commits into from
Jan 28, 2025

Conversation

dotNomad
Copy link
Collaborator

The bats tests utilized the CLI, running various commands and testing behavior.

In an effort to removal legacy CLI code, and prevent the need to update the out-of-date CLI code to keep these tests passing, we have opted for removal.

Intent

Part of #2521

Type of Change

    • Bug Fix
    • New Feature
    • Breaking Change
    • Documentation
    • Refactor
    • Tooling

@dotNomad
Copy link
Collaborator Author

Since this effects the nightly run I ran it targeting this branch. See this run to look at the difference: https://github.com/posit-dev/publisher/actions/runs/13001921866

Notice that the bats-tests are no longer run.

Copy link
Collaborator

@marcosnav marcosnav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✂️

@dotNomad dotNomad merged commit 4d7060e into main Jan 28, 2025
26 of 27 checks passed
@dotNomad dotNomad deleted the dotnomad/rm-bats branch January 28, 2025 19:14
@dotNomad dotNomad added this to the v1.10.0 milestone Jan 28, 2025
@dotNomad dotNomad self-assigned this Jan 28, 2025
@sagerb sagerb mentioned this pull request Jan 29, 2025
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants