Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show Python welcome view when python not a dependency #2571

Merged
merged 1 commit into from
Jan 31, 2025

Conversation

sagerb
Copy link
Collaborator

@sagerb sagerb commented Jan 30, 2025

Intent

Resolves #2529

Type of Change

    • Bug Fix
    • New Feature
    • Breaking Change
    • Documentation
    • Refactor
    • Tooling

Approach

Bug in variable usage; Code was evaluating a reference rather than its value.

User Impact

Bug fixed! Will now see:

2025-01-29 at 4 53 PM

with it showing properly after adding a section

2025-01-29 at 4 54 PM

@sagerb sagerb self-assigned this Jan 30, 2025
Copy link
Collaborator

@dotNomad dotNomad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch and fix 🎉

@sagerb sagerb merged commit 900ca00 into main Jan 31, 2025
13 checks passed
@sagerb sagerb deleted the sagerb-add-python-welcome branch January 31, 2025 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add not configured state for Python Packages view
2 participants