Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show Python welcome view when python not a dependency #2571

Merged
merged 1 commit into from
Jan 31, 2025
Merged

Show Python welcome view when python not a dependency #2571

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions extensions/vscode/webviews/homeView/src/components/views/PythonPackages.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,13 +16,13 @@
Scan
</vscode-button>
</template>
<template v-if="!home.python.active.isInProject">
<template v-else-if="!home.python.active.isInProject">
<p>
This project is not configured to use Python. To configure Python, add
a [python] section to your configuration file.
</p>
</template>
<template v-if="home.python.active.isEmptyRequirements">
<template v-else-if="home.python.active.isEmptyRequirements">
<p>
This project currently has no Python package requirements. If this is
not accurate, click Scan to update based on the files in your project
Expand Down
2 changes: 1 addition & 1 deletion extensions/vscode/webviews/homeView/src/stores/home.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -263,7 +263,7 @@ export const useHomeStore = defineStore("home", () => {
);
}),
isInProject: computed(() => {
return pythonProject;
return pythonProject.value;
}),
},
};
Expand Down