Remove outdated vscode-ui tests (being replaced with e2e tests)

[sagerb]

Intent

Resolves #2585

Type of Change

• • Bug Fix
• • New Feature
• • Breaking Change
• • Documentation
• • Refactor
• • Tooling

Approach

Simply removed.

User Impact

No user impact.

Automated Tests

Directions for Reviewers

Successful CI should validate this enough.

Checklist

• I have updated CHANGELOG.md to cover notable changes.

[jonkeane]

I went looking (though haven't literally RTFSed yet), are the cases that were tested here already written with the new infrastructure?

[sagerb]

I went looking (though haven't literally RTFSed yet), are the cases that were tested here already written with the new infrastructure?

Not quite. I've created an issue that calls this out: #2586 (and outlines what the existing tests were doing).

Since we're not in a rush for the existing PRs blocked by this removal (so that CI will pass), I would feel better if we implemented #2586 ahead of removing these (as long as we can get CI to pass on them). However, it will mean that several of the PRs will be blocked, and that gives me pause. One benefit of prioritizing this would be that the new e2e framework would quickly be used (which would leverage the recent focus that Marcos has on that infrastructure).

I believe this PR can wait on #2586 and I'll tag it as blocked.

[sagerb]

Replacement tests are now ready to merge: #2590.

Once approved, we can merge this in now.

[marcosnav]

🆗