Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove outdated vscode-ui tests (being replaced with e2e tests) #2584

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
95 changes: 0 additions & 95 deletions .github/workflows/contract.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -30,98 +30,3 @@ jobs:
pip install -r test/setup/requirements.txt
CONNECT_SERVER=$(python test/setup/get_ip.py)
echo "CONNECT_SERVER=$CONNECT_SERVER" >> $GITHUB_OUTPUT

vscode-ui-tests:
needs: get-connect-ip
if: ${{ github.event_name == 'schedule' || github.event.inputs.job == 'all' || github.event.inputs.job == 'vscode-ui-tests' }}
env:
FUZZBUCKET_SSH_KEY: ${{ secrets.FUZZBUCKET_SSH_KEY }}
FUZZBUCKET_URL: ${{ secrets.FUZZBUCKET_URL }}
FUZZBUCKET_CREDENTIALS: ${{ secrets.FUZZBUCKET_CREDENTIALS }}
CI: true
CONNECT_SERVER: ${{ needs.get-connect-ip.outputs.connect_ip }}

strategy:
fail-fast: false
matrix:
runs-on: [macos-latest, windows-latest, ubuntu-latest]
runs-on: ${{ matrix.runs-on }}
steps:
- uses: actions/checkout@v4
with:
fetch-depth: 0
- uses: ./.github/actions/setup

- name: setup-chromedriver
uses: nanasess/[email protected]

- name: python
uses: actions/setup-python@v5
with:
python-version: 3.13

- name: R
uses: r-lib/actions/setup-r@v2
with:
r-version: 4.3.0
- name: quarto
uses: quarto-dev/quarto-actions/setup@v2
with:
version: 1.4.549

- uses: actions/download-artifact@v4
with:
name: bin
path: bin

- uses: actions/download-artifact@v4
with:
name: dist
path: dist

- uses: actions/checkout@v4
with:
repository: rstudio/connect-content
path: "test/content"
sparse-checkout: bundles
sparse-checkout-cone-mode: false
token: ${{ secrets.CONNECT_PAT }}

- name: Extract dist on ubuntu
run: |
unzip dist/*-linux-amd64.vsix -d dist/ext
if: matrix.runs-on == 'ubuntu-latest'
- name: Extract dist on windows
run: |
7z x -y dist/*-windows-amd64.vsix -odist/ext
if: matrix.runs-on == 'windows-latest'
- name: Extract dist on macos
run: |
unzip dist/*-darwin-arm64.vsix -d dist/ext
if: matrix.runs-on == 'macos-latest'

- name: Run VSCode UI Tests
run: |
chmod -R +x ./bin
just vscode configure
just vscode-ui install
just vscode-ui test vscode-root
just vscode-ui test vscode-nested

- name: Run nested error scenarios
run: just vscode-ui test vscode-error

- name: Save screenshots
uses: actions/upload-artifact@v4
if: failure()
with:
name: ${{ matrix.runs-on }}-screenshots
path: test/vscode-ui/errorShots
if-no-files-found: ignore
retention-days: 1

# - name: Setup tmate session
# if: ${{ failure() }}
# uses: mxschmitt/action-tmate@v3
# with:
# limit-access-to-actor: true
1 change: 0 additions & 1 deletion .github/workflows/nightly.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ on:
type: choice
options:
- all
- vscode-ui-tests
jobs:
agent:
uses: ./.github/workflows/agent.yaml
Expand Down
13 changes: 0 additions & 13 deletions .github/workflows/pull-request.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -32,16 +32,3 @@ jobs:
- package
uses: ./.github/workflows/upload.yaml
secrets: inherit

# Integration Tests
# bats:
# needs: build
# secrets: inherit
# uses: ./.github/workflows/bats.yaml

vscode-ui:
needs:
- build
- package
secrets: inherit
uses: ./.github/workflows/vscode-ui.yaml
67 changes: 0 additions & 67 deletions .github/workflows/vscode-ui.yaml

This file was deleted.

1 change: 0 additions & 1 deletion .prettierignore
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ extensions/vscode/out
test/sample-content

# webdriver.io service
test/vscode-ui/.wdio-vscode-service
extensions/vscode/dist
extensions/vscode/assets/icons/template/mapping.json
extensions/vscode/node_modules
Expand Down
7 changes: 0 additions & 7 deletions justfile
Original file line number Diff line number Diff line change
Expand Up @@ -263,10 +263,3 @@ vscode *args:
{{ _with_debug }}

just extensions/vscode/{{ args }}

vscode-ui *args:
#!/usr/bin/env bash
set -eou pipefail
{{ _with_debug }}

just test/vscode-ui/{{ args }}
23 changes: 0 additions & 23 deletions test/README.md

This file was deleted.

3 changes: 0 additions & 3 deletions test/vscode-ui/.gitignore

This file was deleted.

1 change: 0 additions & 1 deletion test/vscode-ui/.prettierignore

This file was deleted.

Empty file removed test/vscode-ui/errorShots/.keep
Empty file.
71 changes: 0 additions & 71 deletions test/vscode-ui/justfile

This file was deleted.

Loading
Loading