Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release fixes #925

Merged
merged 5 commits into from
Feb 13, 2025
Merged

Release fixes #925

merged 5 commits into from
Feb 13, 2025

Conversation

rezrah
Copy link
Collaborator

@rezrah rezrah commented Feb 13, 2025 •
edited
Loading

Summary

Hotfixes for #916

  • Downgrades clsx to match fixed version used in dotcom.
  • Fixes RiverStoryScroll with disabled prop, by rendering the children directly. This prevents all animation styles from applying.
Before After

Screenshot 2025-02-13 at 14 34 53

Screenshot 2025-02-13 at 14 33 14

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Feb 13, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 3c88951

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes changesets to release 6 packages
Name Type
@primer/react-brand Patch
@primer/brand-primitives Patch
@primer/brand-e2e Patch
@primer/brand-fonts Patch
@primer/brand-config Patch
@primer/brand-storybook Patch

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@rezrah rezrah requested a review from danielguillan February 13, 2025 14:15
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 13, 2025 •
edited
Loading

🟢 No design token changes found

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 13, 2025 •
edited
Loading

🟢 No visual differences found

Our visual comparison tests did not find any differences in the UI.

@rezrah rezrah changed the title Downgrade clsx to v1 Release fixes Feb 13, 2025
@rezrah rezrah mentioned this pull request Feb 13, 2025
Merged
@rezrah rezrah requested a review from joshfarrant February 13, 2025 14:42
@rezrah rezrah merged commit 2865919 into main Feb 13, 2025
17 checks passed
@rezrah rezrah deleted the rezrah/downgrade-clsx branch February 13, 2025 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielguillan danielguillan danielguillan approved these changes

@joshfarrant joshfarrant joshfarrant approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rezrah @danielguillan @joshfarrant