Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release fixes #925

Merged
merged 5 commits into from
Feb 13, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .changeset/brown-spoons-think.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,6 @@
'@primer/react-brand': patch
---

Updated the following library depedencies: `@oddbird/popover-polyfill`, `clsx`, `autoprefixer`, `css-loader`, `mini-css-extract-plugin`, `postcss`, `postcss-loader`, `postcss-preset-env`, `style-loader`, `typed-css-modules`, `typescript-plugin-css-modules`, `webpack-cli`, `fast-glob`.
Updated the following library depedencies: `@oddbird/popover-polyfill`, `autoprefixer`, `css-loader`, `mini-css-extract-plugin`, `postcss`, `postcss-loader`, `postcss-preset-env`, `style-loader`, `typed-css-modules`, `typescript-plugin-css-modules`, `webpack-cli`, `fast-glob`.

These updates should not affect the library’s visuals or component APIs. **In most cases, no additional action is required**. Please note however, that the compiled output may be slightly different due to changes in the bundling process.
2 changes: 1 addition & 1 deletion .changeset/strong-emus-leave.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,4 @@
'@primer/react-brand': patch
---

Fix `RiverStoryScroll` scrolling bug when `disabled={true}`
Fix `RiverStoryScroll` scrolling bug when `disabled={true}`. Now renders `children` 1:1.
30 changes: 15 additions & 15 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion packages/react/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@
"dependencies": {
"@oddbird/popover-polyfill": "0.5.2",
"@primer/behaviors": "1.8.0",
"clsx": "2.1.1"
"clsx": "1.2.1"
},
"devDependencies": {
"@figma/code-connect": "1.2.4",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ export function RiverStoryScroll({children, disabled}: RiverStoryScrollProps) {
}, [disabled, prefersReducedMotion])

if (disabled || prefersReducedMotion) {
return <div className={clsx(styles.RiverStoryScroll, styles['RiverStoryScroll--disabled'])}>{Children}</div>
return <>{children}</>
}

return (
Expand Down
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading