test: stop the paired-mousemove test racing a 16ms wall-clock window - #90
Merged
Conversation
`usePointerLock` suppresses the mousemove that Chromium pairs with a pointermove by checking `performance.now() - lastPointerMoveAt < 16`. The test dispatches the pair on consecutive lines and expects the second to be dropped. That makes real elapsed time part of the assertion. On a loaded CI runner more than 16ms can pass between those two dispatches, the mousemove is taken as a second movement, and the pointer reads 0.7 instead of 0.6 -- a red build with nothing wrong in the code. It failed exactly this way on PR #87, which touches only apps/desktop, while the identical desktop copy of the test passed in the same run. Freezes performance.now across the paired dispatch in both copies. Confirmed by running the same test with a clock stepping 20ms per call, which reproduces the CI diff exactly (0.7 vs 0.6). Nothing that ships changes -- the 16ms window is still the shipped behaviour, it just is not a race in the test any more. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013FGWJHRL6B6ExLg25UenBS
ThreatCrush Security Scan72 finding(s) HIGH/CRITICAL: 13 | MEDIUM: 41 | LOW: 18
…and 22 more. Full results in the Security tab. Snippets are redacted; ThreatCrush never prints matched credential material. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
usePointerLockdrops themousemovethat Chromium pairs with apointermoveby checking a wall clock:The test dispatches that pair on consecutive lines and asserts the second is ignored — so real elapsed time is part of the assertion. On a loaded CI runner more than 16ms can pass between those two lines, the mousemove is taken as a second movement, and the virtual pointer reads
0.7instead of0.6.That is what turned #87 red. It changes only
apps/desktop/src/main/**, yet failed inapps/web, while the byte-identical desktop copy of the same test passed in the same run. A plain re-run went green, which is the signature of a flake rather than a break.The fix
Freeze
performance.now()across the paired dispatch, in both copies of the test. Scoped to just those twodispatchEventcalls and restored in afinally, so everything else in the test still runs on real time.Nothing that ships changes. The 16ms window is still the shipped behaviour — it simply is no longer a race in the test.
Confirming the diagnosis
Rather than assume, I re-ran the same test with a clock stepping 20ms per call (just past the window) and it reproduced CI's diff exactly:
Same two values, same direction. With the clock frozen it passes.
Checks
The pre-commit hook was bypassed — its parallel turbo fan-out OOMs on this machine. The gates were run individually instead, all green:
npx vitest runinapps/web— 864 tests across 82 filesnpx vitest runinapps/desktop— 609 tests across 58 filestypecheckon both apps — cleanlinton both apps — clean (2 pre-existing warnings inapps/web, untouched here)prettier --checkon both changed files🤖 Generated with Claude Code
https://claude.ai/code/session_013FGWJHRL6B6ExLg25UenBS