Skip to content

test: stop the paired-mousemove test racing a 16ms wall-clock window #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ralyodio merged 1 commit into from
Aug 29, 2026
Merged

test: stop the paired-mousemove test racing a 16ms wall-clock window #90

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 20 additions & 8 deletions apps/desktop/src/renderer/components/control/InputCapture.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,6 +198,13 @@ describe('InputCapture pointer lock', () => {
);
});

// The paired mousemove is suppressed by a 16ms window on performance.now(),
// so the real wall-clock gap between the two dispatches below decides the
// outcome. On a loaded machine that gap can exceed 16ms, the mousemove lands
// as a second movement, and the pointer reads 0.7 instead of 0.6 -- a flaky
// test rather than a regression. Freeze the clock across the pair so the
// window is not a race. Only these two dispatches are covered; everything
// else in the test still runs on real time.
it('does not count a paired mousemove twice after pointermove', () => {
const browser = installBrowserApis();
const onInputEvent = vi.fn();
Expand All @@ -208,14 +215,19 @@ describe('InputCapture pointer lock', () => {
browser.grantLock(container);
});

act(() => {
document.dispatchEvent(
Object.assign(new MouseEvent('pointermove'), { movementX: 100, movementY: 50 })
);
document.dispatchEvent(
Object.assign(new MouseEvent('mousemove'), { movementX: 100, movementY: 50 })
);
});
const now = vi.spyOn(performance, 'now').mockReturnValue(1000);
try {
act(() => {
document.dispatchEvent(
Object.assign(new MouseEvent('pointermove'), { movementX: 100, movementY: 50 })
);
document.dispatchEvent(
Object.assign(new MouseEvent('mousemove'), { movementX: 100, movementY: 50 })
);
});
} finally {
now.mockRestore();
}

onInputEvent.mockClear();
act(() => {
Expand Down
28 changes: 20 additions & 8 deletions apps/web/src/components/control/InputCapture.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,6 +198,13 @@ describe('InputCapture pointer lock', () => {
);
});

// The paired mousemove is suppressed by a 16ms window on performance.now(),
// so the real wall-clock gap between the two dispatches below decides the
// outcome. On a loaded machine that gap can exceed 16ms, the mousemove lands
// as a second movement, and the pointer reads 0.7 instead of 0.6 -- a flaky
// test rather than a regression. Freeze the clock across the pair so the
// window is not a race. Only these two dispatches are covered; everything
// else in the test still runs on real time.
it('does not count a paired mousemove twice after pointermove', () => {
const browser = installBrowserApis();
const onInputEvent = vi.fn();
Expand All @@ -208,14 +215,19 @@ describe('InputCapture pointer lock', () => {
browser.grantLock(container);
});

act(() => {
document.dispatchEvent(
Object.assign(new MouseEvent('pointermove'), { movementX: 100, movementY: 50 })
);
document.dispatchEvent(
Object.assign(new MouseEvent('mousemove'), { movementX: 100, movementY: 50 })
);
});
const now = vi.spyOn(performance, 'now').mockReturnValue(1000);
try {
act(() => {
document.dispatchEvent(
Object.assign(new MouseEvent('pointermove'), { movementX: 100, movementY: 50 })
);
document.dispatchEvent(
Object.assign(new MouseEvent('mousemove'), { movementX: 100, movementY: 50 })
);
});
} finally {
now.mockRestore();
}

onInputEvent.mockClear();
act(() => {
Expand Down
Loading