Ensuring that AadMetadata and EncryptionAlgorithm initialization is deterministic#251
Merged
argmarco-tkd merged 1 commit intodev_argmarco_testutilfrom Feb 20, 2026
Merged
Conversation
|
Thanks for opening a pull request! If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project. Then could you also rename the pull request title in the following format? or See also: |
76a6518 to
1e4aabf
Compare
39959b7 to
95bb0b2
Compare
1e4aabf to
94ce57e
Compare
…erministically (PR#251)
94ce57e to
896aef0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensuring that
AadMetadataandEncryptionAlgorithminitialization is deterministicWe found that GitHub Actions for MinGW complained with an error similar to
The root cause of this error was tracked down to the fields of
AadMetadata(parquet/types.h) andEncryptionAlgorithmand (parquet/metadata.cc) not being consistently initialized (essentially, they were left to being initialized to whatever the platform/OS/environment decided to).In this change, we ensure that the data structures are initialized in a deterministic fashion.
Tests
ctest -L parquet)