Skip to content

Ensuring that AadMetadata and EncryptionAlgorithm initialization is deterministic#251

Merged
argmarco-tkd merged 1 commit intodev_argmarco_testutilfrom
dev_fix_mingw
Feb 20, 2026
Merged

Ensuring that AadMetadata and EncryptionAlgorithm initialization is deterministic#251
argmarco-tkd merged 1 commit intodev_argmarco_testutilfrom
dev_fix_mingw

Conversation

@argmarco-tkd
Copy link
Collaborator

@argmarco-tkd argmarco-tkd commented Feb 17, 2026

Ensuring that AadMetadata and EncryptionAlgorithm initialization is deterministic

We found that GitHub Actions for MinGW complained with an error similar to

Expected: decryptor_.DecryptFile(file_path, dec_props) doesn't throw an exception.
  Actual: it throws parquet::ParquetException with description "Couldn't deserialize thrift: TProtocolException: Invalid data
".

The root cause of this error was tracked down to the fields of AadMetadata (parquet/types.h) and EncryptionAlgorithm and (parquet/metadata.cc) not being consistently initialized (essentially, they were left to being initialized to whatever the platform/OS/environment decided to).

In this change, we ensure that the data structures are initialized in a deterministic fashion.

Tests

@github-actions
Copy link

Thanks for opening a pull request!

If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose

Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project.

Then could you also rename the pull request title in the following format?

GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}

or

MINOR: [${COMPONENT}] ${SUMMARY}

See also:

Copy link
Collaborator

@sofia-tekdatum sofia-tekdatum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@argmarco-tkd argmarco-tkd merged commit 896aef0 into dev_argmarco_testutil Feb 20, 2026
42 of 101 checks passed
@argmarco-tkd argmarco-tkd deleted the dev_fix_mingw branch February 20, 2026 21:09
@argmarco-tkd argmarco-tkd linked an issue Feb 23, 2026 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Git merging > Cleanup final failing Github actions

2 participants