-
-
Notifications
You must be signed in to change notification settings - Fork 600
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unified entry point for models and parameter sets #4490
base: develop
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #4490 +/- ##
===========================================
- Coverage 98.71% 98.69% -0.02%
===========================================
Files 304 305 +1
Lines 23509 23530 +21
===========================================
+ Hits 23207 23224 +17
- Misses 302 306 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good start @santacodes, looks like this is still a WIP? Still I have commented just a tip hoping it'd make sense.
There are some conflicts that you may want to resolve and also feel free to add [WIP] prefix to your PR title while you're on it.
faa78bc
to
164f71e
Compare
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
8a90a9b
to
8da0b01
Compare
@santacodes Are you still working on this? |
Yes I am, it has yet to be reviewed, I will update this branch and request a review again. |
f06b1a1
to
b662073
Compare
b662073
to
298e306
Compare
Resolving merge conflicts on my branch was causing a lot of problems and it was staging a lot of files that weren't modified by me during the merge for some reason, anyway it was a small change so I manually wrote a patch file and applied the patch after resetting this branch so the history is gone. This PR still needs a review to get it merged, and this PR is directly related to - pybamm-team/pybamm.org#258 so it might be good if we have a base entry points API before the GSoC timeline. |
Bumping this @valentinsulzer @agriyakhetarpal @arjxn-py as I cannot request a re-review |
Description
Modified the existing
parameter_sets
API and unified entry points to accommodatemodel entry points
. This is an extension of the existing model entry points in thepybamm-cookie
project. Relevant discussion.Fixes # (issue)
Type of change
Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.
Key checklist:
$ pre-commit run
(or$ nox -s pre-commit
) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)$ python run-tests.py --all
(or$ nox -s tests
)$ python run-tests.py --doctest
(or$ nox -s doctests
)You can run integration tests, unit tests, and doctests together at once, using
$ python run-tests.py --quick
(or$ nox -s quick
).Further checks: