-
-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GSoC '25 project idea proposal #258
Conversation
✅ Deploy Preview for pybamm-developer-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the start, @santacodes! This is awesome. I left a few comments on the copy, and on what we can add to this memo to ensure we can have better-scoped proposals.
We can also leave in a few additional links, such as this old tutorial: https://docs.pybamm.org/en/v22.8/tutorials/add-model.html and the OxRSE course: https://train.rse.ox.ac.uk/material/HPCu/libraries/pybamm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding this, @santacodes! See my comments below -
Edit: Aha, just saw @agriyakhetarpal's review. Please feel free to work on his comments before and then I can update my review.
Ah, @Saransh-cpp and I were reviewing at the same time :) |
Co-authored-by: Saransh Chopra <[email protected]> Co-authored-by: Agriya Khetarpal <[email protected]>
Co-authored-by: Saransh Chopra <[email protected]>
Co-authored-by: Agriya Khetarpal <[email protected]>
Thank you for the suggestions, @Saransh-cpp @agriyakhetarpal. I batched and committed most of the suggestions that didn't have any comments, I will address the comments and add those changes. Meanwhile, feel free to review/suggest more if you have anything, especially in the context of this project, as it would be really helpful to give a good direction for the student whoever takes up this project. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, much cleaner now! Just a couple of more comments -
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now! Thanks, @santacodes! Some language fixes below -
Co-authored-by: Saransh Chopra <[email protected]>
Co-authored-by: Saransh Chopra <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few comments, I'm happy to approve/merge after this. Thanks, @santacodes!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great now, thanks for putting this together, @santacodes!
Co-authored-by: Agriya Khetarpal <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @santacodes 🚀
This idea proposal is an extension of my work from last year on model entry points and the copier/cookiecutter template.
TL;DR
cc - @valentinsulzer @agriyakhetarpal @brosaplanella I would love to hear your thoughts and suggestions if you have anything to add or remove.