-
Notifications
You must be signed in to change notification settings - Fork 387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: migrate to tox 4.x #691
Conversation
Note that py was also removed as a dependency from pytest. See pytest-dev/pytest@19dda7c |
dcfe152
to
9642ec6
Compare
tox-wheel is a deprecated package. tox 4.x includes wheel support.
Codecov ReportBase: 94.67% // Head: 94.65% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #691 +/- ##
==========================================
- Coverage 94.67% 94.65% -0.03%
==========================================
Files 56 57 +1
Lines 8338 8339 +1
==========================================
- Hits 7894 7893 -1
- Misses 444 446 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Note that the release.yml github actions workflow should probably be tested. I'm unsure on how to trigger that. |
Hello, Thank you for this. The |
After looking at it a bit more, I agree that it shouldn't be part of this PR. I just put together a PR over at #692 to get that conversation going. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you
Going to merge as don't see a reason to hold off on this. Thanks @bringhurst ! |
Why is this needed?
tox-wheel is a deprecated package now that tox 4.x includes wheel support.
Example error message
When this issue occurs, you may see an error message similar to:
Proposed Changes
Does this PR introduce any breaking change?
No. Build time changes only.