be explicit about task feature in TL #2918
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D77905821 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2918 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 212 212
Lines 19818 19818
=========================================
Hits 19818 19818 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
sdaulton
added a commit
to sdaulton/botorch
that referenced
this pull request
Jul 8, 2025
Summary: X-link: facebook/Ax#4021 Previously, the TL adapter added a task feature to `SearchSpaceDigest.task_features`, but not to `SearchSpaceDigest.bounds` or `SearchSpaceDigest.feature_names`. This avoided needing to pass the task feature as a fixed_feature when making predictions or generating. However, there was a bug when using `Normalize` that dropped one non-task feature here: https://github.com/facebook/Ax/blob/main/ax/generators/torch/botorch_modular/surrogate.py#L247-L250 This diff adds the task feature to `SearchSpaceDigest.bounds`, `SearchSpaceDigest.feature_names`, and `MultiTaskDataset.feature_names` in order to be explicity about all features/bounds. This requires also adding the task feature as a fixed feature before generating, predicting, and cross-validating. Reviewed By: saitcakmak Differential Revision: D77905821
sdaulton
force-pushed
the
export-D77905821
branch
from
6c6134c to
943146b
Compare
sdaulton
added a commit
to sdaulton/Ax-1
that referenced
this pull request
Jul 8, 2025
Summary: X-link: pytorch/botorch#2918 Previously, the TL adapter added a task feature to `SearchSpaceDigest.task_features`, but not to `SearchSpaceDigest.bounds` or `SearchSpaceDigest.feature_names`. This avoided needing to pass the task feature as a fixed_feature when making predictions or generating. However, there was a bug when using `Normalize` that dropped one non-task feature here: https://github.com/facebook/Ax/blob/main/ax/generators/torch/botorch_modular/surrogate.py#L247-L250 This diff adds the task feature to `SearchSpaceDigest.bounds`, `SearchSpaceDigest.feature_names`, and `MultiTaskDataset.feature_names` in order to be explicity about all features/bounds. This requires also adding the task feature as a fixed feature before generating, predicting, and cross-validating. Reviewed By: saitcakmak Differential Revision: D77905821
sdaulton
added a commit
to sdaulton/Ax-1
that referenced
this pull request
Jul 8, 2025
Summary: X-link: pytorch/botorch#2918 Previously, the TL adapter added a task feature to `SearchSpaceDigest.task_features`, but not to `SearchSpaceDigest.bounds` or `SearchSpaceDigest.feature_names`. This avoided needing to pass the task feature as a fixed_feature when making predictions or generating. However, there was a bug when using `Normalize` that dropped one non-task feature here: https://github.com/facebook/Ax/blob/main/ax/generators/torch/botorch_modular/surrogate.py#L247-L250 This diff adds the task feature to `SearchSpaceDigest.bounds`, `SearchSpaceDigest.feature_names`, and `MultiTaskDataset.feature_names` in order to be explicity about all features/bounds. This requires also adding the task feature as a fixed feature before generating, predicting, and cross-validating. Reviewed By: saitcakmak Differential Revision: D77905821
|
This pull request was exported from Phabricator. Differential Revision: D77905821 |
sdaulton
added a commit
to sdaulton/botorch
that referenced
this pull request
Jul 8, 2025
Summary: Pull Request resolved: pytorch#2918 X-link: facebook/Ax#4021 Previously, the TL adapter added a task feature to `SearchSpaceDigest.task_features`, but not to `SearchSpaceDigest.bounds` or `SearchSpaceDigest.feature_names`. This avoided needing to pass the task feature as a fixed_feature when making predictions or generating. However, there was a bug when using `Normalize` that dropped one non-task feature here: https://github.com/facebook/Ax/blob/main/ax/generators/torch/botorch_modular/surrogate.py#L247-L250 This diff adds the task feature to `SearchSpaceDigest.bounds`, `SearchSpaceDigest.feature_names`, and `MultiTaskDataset.feature_names` in order to be explicity about all features/bounds. This requires also adding the task feature as a fixed feature before generating, predicting, and cross-validating. Reviewed By: saitcakmak Differential Revision: D77905821
sdaulton
force-pushed
the
export-D77905821
branch
from
943146b to
7abde84
Compare
sdaulton
added a commit
to sdaulton/Ax-1
that referenced
this pull request
Jul 8, 2025
Summary: X-link: pytorch/botorch#2918 Pull Request resolved: facebook#4021 Previously, the TL adapter added a task feature to `SearchSpaceDigest.task_features`, but not to `SearchSpaceDigest.bounds` or `SearchSpaceDigest.feature_names`. This avoided needing to pass the task feature as a fixed_feature when making predictions or generating. However, there was a bug when using `Normalize` that dropped one non-task feature here: https://github.com/facebook/Ax/blob/main/ax/generators/torch/botorch_modular/surrogate.py#L247-L250 This diff adds the task feature to `SearchSpaceDigest.bounds`, `SearchSpaceDigest.feature_names`, and `MultiTaskDataset.feature_names` in order to be explicity about all features/bounds. This requires also adding the task feature as a fixed feature before generating, predicting, and cross-validating. Reviewed By: saitcakmak Differential Revision: D77905821
sdaulton
added a commit
to sdaulton/botorch
that referenced
this pull request
Jul 10, 2025
Summary: X-link: facebook/Ax#4021 Previously, the TL adapter added a task feature to `SearchSpaceDigest.task_features`, but not to `SearchSpaceDigest.bounds` or `SearchSpaceDigest.feature_names`. This avoided needing to pass the task feature as a fixed_feature when making predictions or generating. However, there was a bug when using `Normalize` that dropped one non-task feature here: https://github.com/facebook/Ax/blob/main/ax/generators/torch/botorch_modular/surrogate.py#L247-L250 This diff adds the task feature to `SearchSpaceDigest.bounds`, `SearchSpaceDigest.feature_names`, and `MultiTaskDataset.feature_names` in order to be explicity about all features/bounds. This requires also adding the task feature as a fixed feature before generating, predicting, and cross-validating. Reviewed By: saitcakmak Differential Revision: D77905821
sdaulton
force-pushed
the
export-D77905821
branch
from
7abde84 to
5df5641
Compare
sdaulton
added a commit
to sdaulton/Ax-1
that referenced
this pull request
Jul 10, 2025
Summary: X-link: pytorch/botorch#2918 Previously, the TL adapter added a task feature to `SearchSpaceDigest.task_features`, but not to `SearchSpaceDigest.bounds` or `SearchSpaceDigest.feature_names`. This avoided needing to pass the task feature as a fixed_feature when making predictions or generating. However, there was a bug when using `Normalize` that dropped one non-task feature here: https://github.com/facebook/Ax/blob/main/ax/generators/torch/botorch_modular/surrogate.py#L247-L250 This diff adds the task feature to `SearchSpaceDigest.bounds`, `SearchSpaceDigest.feature_names`, and `MultiTaskDataset.feature_names` in order to be explicity about all features/bounds. This requires also adding the task feature as a fixed feature before generating, predicting, and cross-validating. Reviewed By: saitcakmak Differential Revision: D77905821
sdaulton
added a commit
to sdaulton/Ax-1
that referenced
this pull request
Jul 10, 2025
Summary: X-link: pytorch/botorch#2918 Pull Request resolved: facebook#4021 Previously, the TL adapter added a task feature to `SearchSpaceDigest.task_features`, but not to `SearchSpaceDigest.bounds` or `SearchSpaceDigest.feature_names`. This avoided needing to pass the task feature as a fixed_feature when making predictions or generating. However, there was a bug when using `Normalize` that dropped one non-task feature here: https://github.com/facebook/Ax/blob/main/ax/generators/torch/botorch_modular/surrogate.py#L247-L250 This diff adds the task feature to `SearchSpaceDigest.bounds`, `SearchSpaceDigest.feature_names`, and `MultiTaskDataset.feature_names` in order to be explicity about all features/bounds. This requires also adding the task feature as a fixed feature before generating, predicting, and cross-validating. Reviewed By: saitcakmak Differential Revision: D77905821
|
This pull request was exported from Phabricator. Differential Revision: D77905821 |
sdaulton
added a commit
to sdaulton/botorch
that referenced
this pull request
Jul 10, 2025
Summary: Pull Request resolved: pytorch#2918 X-link: facebook/Ax#4021 Previously, the TL adapter added a task feature to `SearchSpaceDigest.task_features`, but not to `SearchSpaceDigest.bounds` or `SearchSpaceDigest.feature_names`. This avoided needing to pass the task feature as a fixed_feature when making predictions or generating. However, there was a bug when using `Normalize` that dropped one non-task feature here: https://github.com/facebook/Ax/blob/main/ax/generators/torch/botorch_modular/surrogate.py#L247-L250 This diff adds the task feature to `SearchSpaceDigest.bounds`, `SearchSpaceDigest.feature_names`, and `MultiTaskDataset.feature_names` in order to be explicity about all features/bounds. This requires also adding the task feature as a fixed feature before generating, predicting, and cross-validating. Reviewed By: saitcakmak Differential Revision: D77905821
sdaulton
force-pushed
the
export-D77905821
branch
from
5df5641 to
2358e05
Compare
sdaulton
added a commit
to sdaulton/botorch
that referenced
this pull request
Jul 15, 2025
Summary: X-link: facebook/Ax#4021 Previously, the TL adapter added a task feature to `SearchSpaceDigest.task_features`, but not to `SearchSpaceDigest.bounds` or `SearchSpaceDigest.feature_names`. This avoided needing to pass the task feature as a fixed_feature when making predictions or generating. However, there was a bug when using `Normalize` that dropped one non-task feature here: https://github.com/facebook/Ax/blob/main/ax/generators/torch/botorch_modular/surrogate.py#L247-L250 This diff adds the task feature to via a new Transform. This significantly simplifies task feature handling across Adapter methods. Reviewed By: saitcakmak Differential Revision: D77905821
sdaulton
force-pushed
the
export-D77905821
branch
from
2358e05 to
8c8f5a8
Compare
|
This pull request was exported from Phabricator. Differential Revision: D77905821 |
sdaulton
added a commit
to sdaulton/Ax-1
that referenced
this pull request
Jul 15, 2025
Summary: X-link: pytorch/botorch#2918 Previously, the TL adapter added a task feature to `SearchSpaceDigest.task_features`, but not to `SearchSpaceDigest.bounds` or `SearchSpaceDigest.feature_names`. This avoided needing to pass the task feature as a fixed_feature when making predictions or generating. However, there was a bug when using `Normalize` that dropped one non-task feature here: https://github.com/facebook/Ax/blob/main/ax/generators/torch/botorch_modular/surrogate.py#L247-L250 This diff adds the task feature to via a new Transform. This significantly simplifies task feature handling across Adapter methods. Reviewed By: saitcakmak Differential Revision: D77905821
sdaulton
added a commit
to sdaulton/Ax-1
that referenced
this pull request
Jul 15, 2025
Summary: X-link: pytorch/botorch#2918 Pull Request resolved: facebook#4021 Previously, the TL adapter added a task feature to `SearchSpaceDigest.task_features`, but not to `SearchSpaceDigest.bounds` or `SearchSpaceDigest.feature_names`. This avoided needing to pass the task feature as a fixed_feature when making predictions or generating. However, there was a bug when using `Normalize` that dropped one non-task feature here: https://github.com/facebook/Ax/blob/main/ax/generators/torch/botorch_modular/surrogate.py#L247-L250 This diff adds the task feature to via a new Transform. This significantly simplifies task feature handling across Adapter methods. Reviewed By: saitcakmak Differential Revision: D77905821
|
This pull request was exported from Phabricator. Differential Revision: D77905821 |
sdaulton
added a commit
to sdaulton/botorch
that referenced
this pull request
Jul 15, 2025
Summary: Pull Request resolved: pytorch#2918 X-link: facebook/Ax#4021 Previously, the TL adapter added a task feature to `SearchSpaceDigest.task_features`, but not to `SearchSpaceDigest.bounds` or `SearchSpaceDigest.feature_names`. This avoided needing to pass the task feature as a fixed_feature when making predictions or generating. However, there was a bug when using `Normalize` that dropped one non-task feature here: https://github.com/facebook/Ax/blob/main/ax/generators/torch/botorch_modular/surrogate.py#L247-L250 This diff adds the task feature to via a new Transform. This significantly simplifies task feature handling across Adapter methods. Reviewed By: saitcakmak Differential Revision: D77905821
sdaulton
force-pushed
the
export-D77905821
branch
from
8c8f5a8 to
68e334d
Compare
sdaulton
added a commit
to sdaulton/Ax-1
that referenced
this pull request
Jul 15, 2025
Summary: X-link: pytorch/botorch#2918 Pull Request resolved: facebook#4021 Previously, the TL adapter added a task feature to `SearchSpaceDigest.task_features`, but not to `SearchSpaceDigest.bounds` or `SearchSpaceDigest.feature_names`. This avoided needing to pass the task feature as a fixed_feature when making predictions or generating. However, there was a bug when using `Normalize` that dropped one non-task feature here: https://github.com/facebook/Ax/blob/main/ax/generators/torch/botorch_modular/surrogate.py#L247-L250 This diff adds the task feature to via a new Transform. This significantly simplifies task feature handling across Adapter methods. Reviewed By: saitcakmak Differential Revision: D77905821
|
This pull request was exported from Phabricator. Differential Revision: D77905821 |
sdaulton
added a commit
to sdaulton/botorch
that referenced
this pull request
Jul 15, 2025
Summary: Pull Request resolved: pytorch#2918 X-link: facebook/Ax#4021 Previously, the TL adapter added a task feature to `SearchSpaceDigest.task_features`, but not to `SearchSpaceDigest.bounds` or `SearchSpaceDigest.feature_names`. This avoided needing to pass the task feature as a fixed_feature when making predictions or generating. However, there was a bug when using `Normalize` that dropped one non-task feature here: https://github.com/facebook/Ax/blob/main/ax/generators/torch/botorch_modular/surrogate.py#L247-L250 This diff adds the task feature to via a new Transform. This significantly simplifies task feature handling across Adapter methods. Reviewed By: saitcakmak Differential Revision: D77905821
sdaulton
force-pushed
the
export-D77905821
branch
from
68e334d to
2d47834
Compare
sdaulton
added a commit
to sdaulton/Ax-1
that referenced
this pull request
Jul 15, 2025
Summary: X-link: pytorch/botorch#2918 Pull Request resolved: facebook#4021 Previously, the TL adapter added a task feature to `SearchSpaceDigest.task_features`, but not to `SearchSpaceDigest.bounds` or `SearchSpaceDigest.feature_names`. This avoided needing to pass the task feature as a fixed_feature when making predictions or generating. However, there was a bug when using `Normalize` that dropped one non-task feature here: https://github.com/facebook/Ax/blob/main/ax/generators/torch/botorch_modular/surrogate.py#L247-L250 This diff adds the task feature to via a new Transform. This significantly simplifies task feature handling across Adapter methods. Reviewed By: saitcakmak Differential Revision: D77905821
|
This pull request was exported from Phabricator. Differential Revision: D77905821 |
sdaulton
added a commit
to sdaulton/botorch
that referenced
this pull request
Jul 15, 2025
Summary: Pull Request resolved: pytorch#2918 X-link: facebook/Ax#4021 Previously, the TL adapter added a task feature to `SearchSpaceDigest.task_features`, but not to `SearchSpaceDigest.bounds` or `SearchSpaceDigest.feature_names`. This avoided needing to pass the task feature as a fixed_feature when making predictions or generating. However, there was a bug when using `Normalize` that dropped one non-task feature here: https://github.com/facebook/Ax/blob/main/ax/generators/torch/botorch_modular/surrogate.py#L247-L250 This diff adds the task feature to via a new Transform. This significantly simplifies task feature handling across Adapter methods. Reviewed By: saitcakmak Differential Revision: D77905821
sdaulton
force-pushed
the
export-D77905821
branch
from
2d47834 to
05a22af
Compare
Summary: Pull Request resolved: pytorch#2918 X-link: facebook/Ax#4021 Previously, the TL adapter added a task feature to `SearchSpaceDigest.task_features`, but not to `SearchSpaceDigest.bounds` or `SearchSpaceDigest.feature_names`. This avoided needing to pass the task feature as a fixed_feature when making predictions or generating. However, there was a bug when using `Normalize` that dropped one non-task feature here: https://github.com/facebook/Ax/blob/main/ax/generators/torch/botorch_modular/surrogate.py#L247-L250 This diff adds the task feature to via a new Transform. This significantly simplifies task feature handling across Adapter methods. Reviewed By: saitcakmak Differential Revision: D77905821
|
This pull request was exported from Phabricator. Differential Revision: D77905821 |
sdaulton
force-pushed
the
export-D77905821
branch
from
05a22af to
3cdbd36
Compare
sdaulton
added a commit
to sdaulton/Ax-1
that referenced
this pull request
Jul 15, 2025
Summary: X-link: pytorch/botorch#2918 Pull Request resolved: facebook#4021 Previously, the TL adapter added a task feature to `SearchSpaceDigest.task_features`, but not to `SearchSpaceDigest.bounds` or `SearchSpaceDigest.feature_names`. This avoided needing to pass the task feature as a fixed_feature when making predictions or generating. However, there was a bug when using `Normalize` that dropped one non-task feature here: https://github.com/facebook/Ax/blob/main/ax/generators/torch/botorch_modular/surrogate.py#L247-L250 This diff adds the task feature to via a new Transform. This significantly simplifies task feature handling across Adapter methods. Reviewed By: saitcakmak Differential Revision: D77905821
facebook-github-bot
pushed a commit
to facebook/Ax
that referenced
this pull request
Jul 15, 2025
Summary: X-link: pytorch/botorch#2918 Pull Request resolved: #4021 Previously, the TL adapter added a task feature to `SearchSpaceDigest.task_features`, but not to `SearchSpaceDigest.bounds` or `SearchSpaceDigest.feature_names`. This avoided needing to pass the task feature as a fixed_feature when making predictions or generating. However, there was a bug when using `Normalize` that dropped one non-task feature here: https://github.com/facebook/Ax/blob/main/ax/generators/torch/botorch_modular/surrogate.py#L247-L250 This diff adds the task feature to via a new Transform. This significantly simplifies task feature handling across Adapter methods. Reviewed By: saitcakmak Differential Revision: D77905821 fbshipit-source-id: 5b71c1eba664850f5e1c7d623327d63b9d633d40
|
This pull request has been merged in 223656a. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
X-link: facebook/Ax#4021
Previously, the TL adapter added a task feature to
SearchSpaceDigest.task_features, but not toSearchSpaceDigest.boundsorSearchSpaceDigest.feature_names. This avoided needing to pass the task feature as a fixed_feature when making predictions or generating.However, there was a bug when using
Normalizethat dropped one non-task feature here: https://github.com/facebook/Ax/blob/main/ax/generators/torch/botorch_modular/surrogate.py#L247-L250This diff adds the task feature to
SearchSpaceDigest.bounds,SearchSpaceDigest.feature_names, andMultiTaskDataset.feature_namesin order to be explicity about all features/bounds. This requires also adding the task feature as a fixed feature before generating, predicting, and cross-validating.Reviewed By: saitcakmak
Differential Revision: D77905821