Skip to content

be explicit about task feature in TL #2918

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

be explicit about task feature in TL #2918

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions botorch/utils/datasets.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,8 +76,8 @@ def __init__(
self._X = X
self._Y = Y
self._Yvar = Yvar
self.feature_names = feature_names
self.outcome_names = outcome_names
self.feature_names = feature_names.copy()
self.outcome_names = outcome_names.copy()
self.group_indices = group_indices
self.validate_init = validate_init
if validate_init:
Expand Down Expand Up @@ -351,7 +351,7 @@ def __init__(
self.target_outcome_name = target_outcome_name
self.task_feature_index = task_feature_index
self._validate_datasets(datasets=datasets)
self.feature_names = self.datasets[target_outcome_name].feature_names
self.feature_names = self.datasets[target_outcome_name].feature_names.copy()
self.outcome_names = [target_outcome_name]

# Check if the datasets have identical feature sets.
Expand Down
4 changes: 2 additions & 2 deletions test/utils/test_datasets.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,8 +235,8 @@ def test_clone(self, supervised: bool = True) -> None:
self.assertIs(dataset._X, dataset2._X)
self.assertIs(dataset._Y, dataset2._Y)
self.assertIs(dataset._Yvar, dataset2._Yvar)
self.assertIs(dataset.feature_names, dataset2.feature_names)
self.assertIs(dataset.outcome_names, dataset2.outcome_names)
self.assertEqual(dataset.feature_names, dataset2.feature_names)
self.assertEqual(dataset.outcome_names, dataset2.outcome_names)
# test with mask
mask = torch.tensor([0, 1, 1], dtype=torch.bool)
if supervised:
Expand Down