Zero Collision Hash Benchmark Framework #3127
Open
+9,315
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D77033290 |
|
This pull request was exported from Phabricator. Differential Revision: D77033290 |
lizhouyu
added a commit
to lizhouyu/torchrec
that referenced
this pull request
Jul 6, 2025
Summary: Pull Request resolved: pytorch#3127 Differential Revision: D77033290
lizhouyu
force-pushed
the
export-D77033290
branch
from
729264d to
f95b8fa
Compare
|
This pull request was exported from Phabricator. Differential Revision: D77033290 |
lizhouyu
added a commit
to lizhouyu/torchrec
that referenced
this pull request
Jul 6, 2025
Summary: Pull Request resolved: pytorch#3127 Differential Revision: D77033290
lizhouyu
force-pushed
the
export-D77033290
branch
from
f95b8fa to
c44d954
Compare
|
This pull request was exported from Phabricator. Differential Revision: D77033290 |
lizhouyu
added a commit
to lizhouyu/torchrec
that referenced
this pull request
Jul 6, 2025
Summary: Pull Request resolved: pytorch#3127 Differential Revision: D77033290
lizhouyu
force-pushed
the
export-D77033290
branch
from
c44d954 to
1a691d5
Compare
|
This pull request was exported from Phabricator. Differential Revision: D77033290 |
lizhouyu
force-pushed
the
export-D77033290
branch
from
1a691d5 to
61b76e8
Compare
lizhouyu
added a commit
to lizhouyu/torchrec
that referenced
this pull request
Jul 6, 2025
Summary: Pull Request resolved: pytorch#3127 Differential Revision: D77033290
lizhouyu
added a commit
to lizhouyu/torchrec
that referenced
this pull request
Jul 6, 2025
Summary: Pull Request resolved: pytorch#3127 Differential Revision: D77033290
|
This pull request was exported from Phabricator. Differential Revision: D77033290 |
lizhouyu
added a commit
to lizhouyu/torchrec
that referenced
this pull request
Jul 8, 2025
Summary: Pull Request resolved: pytorch#3127 Differential Revision: D77033290
lizhouyu
force-pushed
the
export-D77033290
branch
from
61b76e8 to
115412b
Compare
lizhouyu
added a commit
to lizhouyu/torchrec
that referenced
this pull request
Jul 8, 2025
Summary: Pull Request resolved: pytorch#3127 Differential Revision: D77033290
|
This pull request was exported from Phabricator. Differential Revision: D77033290 |
lizhouyu
force-pushed
the
export-D77033290
branch
from
115412b to
c3663f5
Compare
lizhouyu
added a commit
to lizhouyu/torchrec
that referenced
this pull request
Jul 9, 2025
Summary: Pull Request resolved: pytorch#3127 Differential Revision: D77033290
lizhouyu
added a commit
to lizhouyu/torchrec
that referenced
this pull request
Jul 9, 2025
Summary: Pull Request resolved: pytorch#3127 Differential Revision: D77033290
lizhouyu
added a commit
to lizhouyu/torchrec
that referenced
this pull request
Jul 14, 2025
Summary: Pull Request resolved: pytorch#3127 Differential Revision: D77033290
Summary: ### Major changes - Create a `mpzch` folder under the `torchrec/github/examples` folder - Implement a simple SparseArch module with a flag to switch between original and MPZCH managed collision modules - Profile the running time and QPS for model training(GPU)/inference(CPU) - Create a notebook tutorial for ZCH basics and the use of ZCH modules in TorchRec ### ToDos for OSS - When the internal torchrec MPZCH module is OSS - Remove the `BUCK` file - Replace all the `from torchrec.fb.modules` in `sparse_arch.py` to `from torchrec.modules` ### Potential improvement - Add hash collision counter - Show profiling results in the Readme file - Add multi-batch profiling Differential Revision: D75570684 Reviewed By: aporialiao
Summary: Pull Request resolved: pytorch#3127 Differential Revision: D77033290
|
This pull request was exported from Phabricator. Differential Revision: D77033290 |
lizhouyu
force-pushed
the
export-D77033290
branch
from
c3663f5 to
e7c1596
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Differential Revision: D77033290