-
Notifications
You must be signed in to change notification settings - Fork 557
Fix embedding table type and eviction policy in st publish #3309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
EddyLXJ
wants to merge
1
commit into
pytorch:main
Choose a base branch
from
EddyLXJ:export-D80729527
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pull request was exported from Phabricator. Differential Revision: D80729527 |
fa2ef2a
to
0352676
Compare
This pull request was exported from Phabricator. Differential Revision: D80729527 |
EddyLXJ
added a commit
to EddyLXJ/torchrec
that referenced
this pull request
Aug 25, 2025
) Summary: Pull Request resolved: pytorch#3309 As title, fix st publish gap for eviction Reviewed By: zlzhao1104 Differential Revision: D80729527
0352676
to
fc792c5
Compare
fc792c5
to
6d1bb51
Compare
This pull request was exported from Phabricator. Differential Revision: D80729527 |
6d1bb51
to
2c82ed8
Compare
2c82ed8
to
e843878
Compare
This pull request was exported from Phabricator. Differential Revision: D80729527 |
e843878
to
afaa92d
Compare
EddyLXJ
added a commit
to EddyLXJ/torchrec
that referenced
this pull request
Aug 26, 2025
) Summary: Pull Request resolved: pytorch#3309 As title, fix st publish gap for eviction Reviewed By: zlzhao1104 Differential Revision: D80729527
) Summary: Pull Request resolved: pytorch#3309 As title, fix st publish gap for eviction Reviewed By: zlzhao1104 Differential Revision: D80729527
This pull request was exported from Phabricator. Differential Revision: D80729527 |
afaa92d
to
75107f6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
fb-exported
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: As title, fix st publish gap for eviction
Differential Revision: D80729527