Skip to content

Fix embedding table type and eviction policy in st publish #3309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix embedding table type and eviction policy in st publish #3309

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions torchrec/distributed/batched_embedding_kernel.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,12 +225,12 @@ def _populate_zero_collision_tbe_params(
meta_header_lens = [0] * len(config.embedding_tables)
for i, table in enumerate(config.embedding_tables):
# virtual_table_eviction_policy won't be None in reality: https://fburl.com/code/864a0w0f
if table.virtual_table_eviction_policy is not None:
meta_header_lens[i] = (
table.virtual_table_eviction_policy.get_meta_header_len()
)
if not isinstance(table.virtual_table_eviction_policy, NoEvictionPolicy):
enabled = True
assert (
table.virtual_table_eviction_policy is not None
), "virtual_table_eviction_policy for kvzch table should not be None"
meta_header_lens[i] = table.virtual_table_eviction_policy.get_meta_header_len()
if not isinstance(table.virtual_table_eviction_policy, NoEvictionPolicy):
enabled = True
if enabled:
counter_thresholds = [0] * len(config.embedding_tables)
ttls_in_mins = [0] * len(config.embedding_tables)
Expand Down
Loading