Skip to content

Annotate EP with dispatch/compute/combine #1907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Annotate EP with dispatch/compute/combine #1907

wants to merge 1 commit into from

Conversation

@SherlockNoMad
Copy link
Contributor

@SherlockNoMad SherlockNoMad commented Oct 17, 2025 •
edited
Loading

Stack from ghstack (oldest at bottom):

Need to run on top of [https://github.com/pytorch/pytorch/pull/165703]

NGPU=4 CONFIG_FILE=./torchtitan/models/deepseek_v3/train_configs/debug_model.toml ./run_train.sh --model.name joint_graph_runner.deepseek_v3 --compile.enable --parallelism.data_parallel_shard_degree=2 --parallelism.tensor_parallel_degree=2 --parallelism.expert_parallel_degree=2 --activation_checkpoint.mode none

Sample output: P1996227609

@SherlockNoMad SherlockNoMad mentioned this pull request Oct 17, 2025
Merged
SherlockNoMad added a commit that referenced this pull request Oct 17, 2025
@SherlockNoMad
Annotate EP with dispatch/compute/combine
f47d26d 
ghstack-source-id: faa8a54
Pull Request resolved: #1907
@meta-cla meta-cla bot added the CLA Signed This label is managed by the Meta Open Source bot. label Oct 17, 2025
@SherlockNoMad SherlockNoMad mentioned this pull request Oct 17, 2025
Closed
@yushangdi yushangdi mentioned this pull request Oct 17, 2025
Closed
@meta-codesync
Copy link

meta-codesync bot commented Oct 20, 2025

This pull request has been merged in cf3a787.

Chao1Han pushed a commit to Chao1Han/pytorch that referenced this pull request Oct 21, 2025
@yushangdi @Chao1Han
[annotate] Annotate bw nodes before eliminate dead code (pytorch#165782)
0f2c923 
Fixes pytorch/torchtitan#1907

Pull Request resolved: pytorch#165782
Approved by: https://github.com/SherlockNoMad
zhudada0120 pushed a commit to zhudada0120/pytorch that referenced this pull request Oct 22, 2025
@yushangdi @zhudada0120
[annotate] Annotate bw nodes before eliminate dead code (pytorch#165782)
d8fd387 
Fixes pytorch/torchtitan#1907

Pull Request resolved: pytorch#165782
Approved by: https://github.com/SherlockNoMad
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tianyu-l tianyu-l Awaiting requested review from tianyu-l tianyu-l is a code owner

@fegin fegin Awaiting requested review from fegin fegin is a code owner

@wwwjn wwwjn Awaiting requested review from wwwjn wwwjn is a code owner

@wconstab wconstab Awaiting requested review from wconstab wconstab is a code owner

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Meta Open Source bot. Merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@SherlockNoMad @facebook-github-bot