Skip to content

Conversation

@SherlockNoMad
Copy link
Contributor

@SherlockNoMad SherlockNoMad commented Oct 17, 2025

[ghstack-poisoned]
SherlockNoMad added a commit that referenced this pull request Oct 17, 2025
ghstack-source-id: 688b9d6
Pull Request resolved: #1908
@meta-cla meta-cla bot added the CLA Signed This label is managed by the Meta Open Source bot. label Oct 17, 2025
Copy link
Contributor

@wwwjn wwwjn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you help me understand what does these notation for? And it's for joint_graph_runner, right? If we need more notations on the model in the future, it's better to keep a separate copy of Deespeek-v3 model (like simple_fsdp: https://github.com/pytorch/torchtitan/blob/main/torchtitan/experiments/simple_fsdp/deepseek_v3/model.py), so it won't confuse the majority of titan users.

@SherlockNoMad
Copy link
Contributor Author

Can you help me understand what does these notation for? And it's for joint_graph_runner, right? If we need more notations on the model in the future, it's better to keep a separate copy of Deespeek-v3 model (like simple_fsdp: https://github.com/pytorch/torchtitan/blob/main/torchtitan/experiments/simple_fsdp/deepseek_v3/model.py), so it won't confuse the majority of titan users.

yes, it's for joint graph runner.
We will make the clone of the model.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Meta Open Source bot.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants