Skip to content

Fix broken docs-build by pinning protobuf-3.20.x #1033

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 28, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions .github/workflows/doc-build.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -20,16 +20,15 @@ jobs:
architecture: x64
- name: Checkout TorchX
uses: actions/checkout@v2
- name: Install Dependencies
- name: Install Doc Dependencies
run: |
set -eux
sudo apt-get update
sudo apt-get install -y pandoc
pip install -e .[dev]
pip install -r docs/requirements.txt
- name: Install TorchX
run: |
python setup.py develop
pip install -e .[dev]
- name: Start Airflow
run: |
# start airflow in background
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/pyre.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,6 @@ jobs:
set -eux
pip install -e .[dev]
- name: Init Lint Runner
lintrunner init
run: lintrunner init
- name: Run Pyre
run: scripts/pyre.sh
2 changes: 2 additions & 0 deletions dev-requirements.txt
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,8 @@ google-cloud-runtimeconfig==0.34.0
hydra-core
ipython
kfp==1.8.22
# pin protobuf to the version that is required by kfp
protobuf==3.20.3
mlflow-skinny
moto~=5.0.8
pyre-extensions
Expand Down
7 changes: 6 additions & 1 deletion torchx/schedulers/test/ray_scheduler_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -390,7 +390,12 @@ def test_nonmatching_address(self) -> None:
):
_scheduler_with_client.submit(app=app, cfg={})

def _assertDictContainsSubset(self, expected, actual, msg=None):
def _assertDictContainsSubset(
self,
expected: dict[str, Any],
actual: dict[str, Any],
msg: Optional[str] = None,
) -> None:
# NB: implement unittest.TestCase.assertDictContainsSubsetNew() since it was removed in python-3.11
for key, value in expected.items():
self.assertIn(key, actual, msg)
Expand Down
Loading