Fix broken docs-build by pinning protobuf-3.20.x #1033
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D72016216 |
kiukchung
changed the title
facebook-github-bot
force-pushed
the
export-D72016216
branch
from
3f32f8c to
805e953
Compare
|
This pull request was exported from Phabricator. Differential Revision: D72016216 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D72016216 |
kiukchung
added a commit
that referenced
this pull request
Mar 28, 2025
Summary: Pull Request resolved: #1033 `apache-airflow>2.6.3` (installed in `docs/requirements.txt`) transitively brings in `opentelemetry` which depends on `protobuf>=4.x`. This version of `protobuf` conflicts with the one required by `kfp==1.8.x` (`protobuf <= 3.20.x`). What we oughta do is to upgrade to `kfp-2.x` but that's a much more intrusive change as we are bumping major versions. So pin to `apache-airflow==2.6.3` so that protobuf doesn't conflict with kfp. Reviewed By: tonykao8080 Differential Revision: D72016216
kiukchung
force-pushed
the
export-D72016216
branch
from
805e953 to
6f39c6e
Compare
|
This pull request was exported from Phabricator. Differential Revision: D72016216 |
kiukchung
added a commit
that referenced
this pull request
Mar 28, 2025
Summary: Pull Request resolved: #1033 Pin protobuf-3.20.x (required by kfp-1.8.22) in dev-requirements and first install docs/requirements.txt then downgrade protobuf to 3.20.x. What we oughta do is to upgrade to `kfp-2.x` but that's a much more intrusive change as we are bumping major versions. So pin to `apache-airflow==2.6.3` so that protobuf doesn't conflict with kfp. Reviewed By: tonykao8080 Differential Revision: D72016216
kiukchung
force-pushed
the
export-D72016216
branch
from
6f39c6e to
d824757
Compare
kiukchung
changed the title
kiukchung
added a commit
that referenced
this pull request
Mar 28, 2025
Summary: Pull Request resolved: #1033 Pin protobuf-3.20.x (required by kfp-1.8.22) in dev-requirements and first install docs/requirements.txt then downgrade protobuf to 3.20.x. What we oughta do is to upgrade to `kfp-2.x` but that's a much more intrusive change as we are bumping major versions. So pin to `apache-airflow==2.6.3` so that protobuf doesn't conflict with kfp. Reviewed By: tonykao8080 Differential Revision: D72016216
|
This pull request was exported from Phabricator. Differential Revision: D72016216 |
kiukchung
force-pushed
the
export-D72016216
branch
from
d824757 to
5b979cf
Compare
facebook-github-bot
pushed a commit
that referenced
this pull request
Mar 28, 2025
Summary: Pin protobuf-3.20.x (required by kfp-1.8.22) in dev-requirements and first install docs/requirements.txt then downgrade protobuf to 3.20.x. What we oughta do is to upgrade to `kfp-2.x` but that's a much more intrusive change as we are bumping major versions. So pin to `apache-airflow==2.6.3` so that protobuf doesn't conflict with kfp. Reviewed By: tonykao8080 Differential Revision: D72016216
facebook-github-bot
force-pushed
the
export-D72016216
branch
from
5b979cf to
9ffd30f
Compare
|
This pull request was exported from Phabricator. Differential Revision: D72016216 |
facebook-github-bot
pushed a commit
that referenced
this pull request
Mar 28, 2025
Summary: Pin protobuf-3.20.x (required by kfp-1.8.22) in dev-requirements and first install docs/requirements.txt then downgrade protobuf to 3.20.x. What we oughta do is to upgrade to `kfp-2.x` but that's a much more intrusive change as we are bumping major versions. So pin to `apache-airflow==2.6.3` so that protobuf doesn't conflict with kfp. Reviewed By: tonykao8080 Differential Revision: D72016216
facebook-github-bot
force-pushed
the
export-D72016216
branch
from
9ffd30f to
eda24ed
Compare
|
This pull request was exported from Phabricator. Differential Revision: D72016216 |
kiukchung
added a commit
that referenced
this pull request
Mar 28, 2025
Summary: Pin protobuf-3.20.x (required by kfp-1.8.22) in dev-requirements and first install docs/requirements.txt then downgrade protobuf to 3.20.x. What we oughta do is to upgrade to `kfp-2.x` but that's a much more intrusive change as we are bumping major versions. So pin to `apache-airflow==2.6.3` so that protobuf doesn't conflict with kfp. Reviewed By: tonykao8080 Differential Revision: D72016216
kiukchung
force-pushed
the
export-D72016216
branch
from
eda24ed to
9753fa7
Compare
Summary: Pull Request resolved: #1033 Pin protobuf-3.20.x (required by kfp-1.8.22) in dev-requirements and first install docs/requirements.txt then downgrade protobuf to 3.20.x. What we oughta do is to upgrade to `kfp-2.x` but that's a much more intrusive change as we are bumping major versions. So pin to `apache-airflow==2.6.3` so that protobuf doesn't conflict with kfp. Reviewed By: tonykao8080 Differential Revision: D72016216
|
This pull request was exported from Phabricator. Differential Revision: D72016216 |
kiukchung
force-pushed
the
export-D72016216
branch
from
9753fa7 to
3479f02
Compare
facebook-github-bot
pushed a commit
that referenced
this pull request
Mar 28, 2025
Summary: I fixed doc-build in #1033 by: 1. pinning `protobuf-3.20.x` in torchx's `dev-requirements.txt` since `apache-airflow` (defined in `docs/requirements.txt`) was upgrading to `protobuf>=5.x` which is incompatible with `kfp-1.8.x`. 2. installing `doc/requirements.txt` FIRST, then installing `torchx` so that the pinned version of `protobuf` is honored. The above fixes `doc-build` but not `doc-push` because `doc-push` runs `scripts/doc-push.sh` which needed the same change as #2. Differential Revision: D72059926
Merged
kiukchung
added a commit
that referenced
this pull request
Mar 28, 2025
Summary: I fixed doc-build in #1033 by: 1. pinning `protobuf-3.20.x` in torchx's `dev-requirements.txt` since `apache-airflow` (defined in `docs/requirements.txt`) was upgrading to `protobuf>=5.x` which is incompatible with `kfp-1.8.x`. 2. installing `doc/requirements.txt` FIRST, then installing `torchx` so that the pinned version of `protobuf` is honored. The above fixes `doc-build` but not `doc-push` because `doc-push` runs `scripts/doc-push.sh` which needed the same change as #2. NOTE: this wasn't caught in #1033 because we don't run `doc-push` for PRs (doc-push only runs for releases and commits in trunk since it literally pushes the built docs to https://pytorch.org/torchx) Differential Revision: D72059926
kiukchung
added a commit
that referenced
this pull request
Mar 28, 2025
Summary: Pull Request resolved: #1034 I fixed doc-build in #1033 by: 1. pinning `protobuf-3.20.x` in torchx's `dev-requirements.txt` since `apache-airflow` (defined in `docs/requirements.txt`) was upgrading to `protobuf>=5.x` which is incompatible with `kfp-1.8.x`. 2. installing `doc/requirements.txt` FIRST, then installing `torchx` so that the pinned version of `protobuf` is honored. The above fixes `doc-build` but not `doc-push` because `doc-push` runs `scripts/doc-push.sh` which needed the same change as #2. NOTE: this wasn't caught in #1033 because we don't run `doc-push` for PRs (doc-push only runs for releases and commits in trunk since it literally pushes the built docs to https://pytorch.org/torchx) Differential Revision: D72059926
kiukchung
added a commit
that referenced
this pull request
Mar 28, 2025
Summary: Pull Request resolved: #1034 I fixed doc-build in #1033 by: 1. pinning `protobuf-3.20.x` in torchx's `dev-requirements.txt` since `apache-airflow` (defined in `docs/requirements.txt`) was upgrading to `protobuf>=5.x` which is incompatible with `kfp-1.8.x`. 2. installing `doc/requirements.txt` FIRST, then installing `torchx` so that the pinned version of `protobuf` is honored. The above fixes `doc-build` but not `doc-push` because `doc-push` runs `scripts/doc-push.sh` which needed the same change as #2. NOTE: this wasn't caught in #1033 because we don't run `doc-push` for PRs (doc-push only runs for releases and commits in trunk since it literally pushes the built docs to https://pytorch.org/torchx) Differential Revision: D72059926
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Differential Revision: D72016216