[3006][ADD] sale_report_qweb_decimal_place by AungKoKoLin1997 · Pull Request #6 · qrtl/fal-custom

AungKoKoLin1997 · 2023-01-04T08:48:24Z

yostashiro

@AungKoKoLin1997 Can we put the module in https://github.com/OCA/sale-reporting?

yostashiro · 2023-01-05T02:25:55Z

sale_report_qweb_decimal_place/readme/DESCRIPTION.rst

@@ -0,0 +1 @@
+This module provides the price unit format of sale report depends on the choice of price_decimal_places in currency.


Suggested change

This module provides the price unit format of sale report depends on the choice of price_decimal_places in currency.

This module provides the option to adjust the price unit format (number of decimal places to apply)

of sale reports according to the configuration of price_decimal_places in currency.

This module depends on report_qweb_decimal_place module in OCA/reporting-engine.

AungKoKoLin1997 · 2023-01-05T02:42:35Z

@AungKoKoLin1997 Can we put the module in https://github.com/OCA/sale-reporting?

@yostashiro This module is for v 16.0 and we put OCA/reporting-engine#697 is for v 15.0. So, should we create new PR for report_qweb_decimal_place in OCA repo for v16.0 before v15.0 PR is merged? I was planning to create migration PR for report_qweb_decimal_place after this OCA/reporting-engine#697 is merged. That's why I decided to put the modules for v16.0 in fal-custom repo first and later we can put to OCA.

yostashiro · 2023-01-05T02:48:50Z

That's fine but why did we target 15.0 in OCA/reporting-engine#697 in the first place? I think there is currently no direct client needs of such module for 15.0.

AungKoKoLin1997 · 2023-01-05T02:56:07Z

That's fine but why did we target 15.0 in OCA/reporting-engine#697 in the first place? I think there is currently no direct client needs of such module for 15.0.

I don't know the reason. But in the first place, we have 15.0 branch and I have been assigned to create branch for 16.0 in this task https://www.quartile.co/web#id=3061&model=project.task&view_type=form&menu_id=517 and also create new PR for 16.0 branch in #2 (comment)

yostashiro · 2023-01-05T04:18:21Z

sale_report_qweb_decimal_place/reports/sale_report.xml

+        <xpath expr="//td[@name='td_priceunit']/span" position="replace">
+            <t t-set="currency" t-value="doc.currency_id" />
+            <t t-set="price_unit" t-value="line.price_unit" />
+            <t t-call="report_qweb_decimal_place.price_unit_value_format" />
+        </xpath>


Suggested change

<xpath expr="//td[@name='td_priceunit']/span" position="replace">

<t t-set="currency" t-value="doc.currency_id" />

<t t-set="price_unit" t-value="line.price_unit" />

<t t-call="report_qweb_decimal_place.price_unit_value_format" />

</xpath>

<xpath expr="//span[@t-field='line.price_unit']" position="attributes">

<attribute name="t-att-style">'display: none' if doc.currency_id.apply_price_decimal_place else ''</attribute>

</xpath>

<xpath expr="//span[@t-field='line.price_unit']" position="after">

<t t-if="not doc.currency_id.apply_price_decimal_place">

<t t-set="currency" t-value="doc.currency_id" />

<t t-set="price_unit" t-value="line.price_unit" />

<t t-call="report_qweb_decimal_place.price_unit_value_format" />

</t>

</xpath>

To avoid the overuse of replace.

I was wondering if we should actually change the following template from report_qweb_decimal_place

<template id="price_unit_value_format"> <t t-if="currency.apply_price_decimal_place"> <span class="text-nowrap" t-esc="price_unit" t-options='{"widget": "float", "precision": currency.price_decimal_places}' /> </t> <t t-else=""> <span class="text-nowrap" t-field="line.price_unit" /> </t> </template>

to

<template id="price_unit_value_format"> <span class="text-nowrap" t-esc="price_unit" t-options='{"widget": "float", "precision": currency.price_decimal_places}' /> </template>

assuming that the template is called in the above suggested manner. What do you think?

Yes. I think this approach is better.

OK, please go ahead and apply changes to all the relevant places.

yostashiro · 2023-01-05T08:25:30Z

@kakurai8 Please go ahead and install the modules in the test database.

yostashiro · 2023-01-28T15:33:16Z

pre-commit fails with this error. Ran copier update to see if there is any material chnages to .pre-commit-config.yaml, however the result was negative.

An unexpected error has occurred: CalledProcessError: command: ('/home/runner/.cache/pre-commit/repop_5djz1u/py_env-python3/bin/python', '-mpip', 'install', '.')
return code: 1
stdout:
    Processing /home/runner/.cache/pre-commit/repop_5djz1u
      Installing build dependencies: started
      Installing build dependencies: finished with status 'done'
      Getting requirements to build wheel: started
      Getting requirements to build wheel: finished with status 'done'
      Preparing metadata (pyproject.toml): started
      Preparing metadata (pyproject.toml): finished with status 'error'
    
stderr:
      error: subprocess-exited-with-error
      
      × Preparing metadata (pyproject.toml) did not run successfully.
      │ exit code: 1
      ╰─> [17 lines of output]
          Traceback (most recent call last):
            File "/home/runner/.cache/pre-commit/repop_5djz1u/py_env-python3/lib/python3.11/site-packages/pip/_vendor/pep[51](https://github.com/qrtl/fal-custom/actions/runs/4032370245/jobs/6932206851#step:7:52)7/in_process/_in_process.py", line 351, in <module>
              main()
            File "/home/runner/.cache/pre-commit/repop_5djz1u/py_env-python3/lib/python3.11/site-packages/pip/_vendor/pep517/in_process/_in_process.py", line 333, in main
              json_out['return_val'] = hook(**hook_input['kwargs'])
                                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
            File "/home/runner/.cache/pre-commit/repop_5djz1u/py_env-python3/lib/python3.11/site-packages/pip/_vendor/pep517/in_process/_in_process.py", line 1[52](https://github.com/qrtl/fal-custom/actions/runs/4032370245/jobs/6932206851#step:7:53), in prepare_metadata_for_build_wheel
              return hook(metadata_directory, config_settings)
                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
            File "/tmp/pip-build-env-n3ldi3eb/overlay/lib/python3.11/site-packages/poetry/core/masonry/api.py", line 40, in prepare_metadata_for_build_wheel
              poetry = Factory().create_poetry(Path(".").resolve(), with_groups=False)
                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
            File "/tmp/pip-build-env-n3ldi3eb/overlay/lib/python3.11/site-packages/poetry/core/factory.py", line [57](https://github.com/qrtl/fal-custom/actions/runs/4032370245/jobs/6932206851#step:7:58), in create_poetry
              raise RuntimeError("The Poetry configuration is invalid:\n" + message)
          RuntimeError: The Poetry configuration is invalid:
            - [extras.pipfile_deprecated_finder.2] 'pip-shims<=0.3.4' does not match '^[a-zA-Z-_.0-9]+$'
          
          [end of output]
      
      note: This error originates from a subprocess, and is likely not a problem with pip.
    error: metadata-generation-failed
    
    × Encountered error while generating package metadata.
    ╰─> See above for output.
    
    note: This is an issue with the package mentioned above, not pip.
    hint: See above for details.
    
Check the log at /home/runner/.cache/pre-commit/pre-commit.log
Error: Process completed with exit code 3.

yostashiro · 2023-01-28T15:33:50Z

Ran pre-commit locally and confirmed there is no issue.

AungKoKoLin1997 changed the title ~~[ADD] sale_report_qweb_decimal_place~~ [3006][ADD] sale_report_qweb_decimal_place Jan 4, 2023

AungKoKoLin1997 requested review from kakurai8, kanda999 and yostashiro January 4, 2023 08:49

AungKoKoLin1997 force-pushed the 16.0-add-sale_report_qweb_decimal_place branch from 3e89823 to e4bba51 Compare January 4, 2023 13:47

yostashiro requested changes Jan 5, 2023

View reviewed changes

This was referenced Jan 5, 2023

[3006][ADD] account_report_qweb_decimal_place #7

Merged

[3006][ADD] purchase_report_qweb_decimal_place #8

Merged

yostashiro approved these changes Jan 5, 2023

View reviewed changes

yostashiro assigned kakurai8 Jan 5, 2023

AungKoKoLin1997 and others added 5 commits January 28, 2023 15:10

[ADD] sale_report_qweb_decimal_place

d535938

update readme

182eca5

update

3ce63dc

update

78cd98e

add test-requirements.txt

a420832

yostashiro force-pushed the 16.0-add-sale_report_qweb_decimal_place branch from 7e11154 to a420832 Compare January 28, 2023 15:11

yostashiro merged commit 9b899ae into 16.0 Jan 28, 2023

AungKoKoLin1997 deleted the 16.0-add-sale_report_qweb_decimal_place branch March 13, 2023 01:57

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[3006][ADD] sale_report_qweb_decimal_place#6

[3006][ADD] sale_report_qweb_decimal_place#6
yostashiro merged 5 commits into16.0from
16.0-add-sale_report_qweb_decimal_place

AungKoKoLin1997 commented Jan 4, 2023 •

edited

Loading

Uh oh!

yostashiro left a comment

Uh oh!

yostashiro Jan 5, 2023

Uh oh!

AungKoKoLin1997 commented Jan 5, 2023

Uh oh!

yostashiro commented Jan 5, 2023

Uh oh!

AungKoKoLin1997 commented Jan 5, 2023

Uh oh!

yostashiro Jan 5, 2023

Uh oh!

AungKoKoLin1997 Jan 5, 2023

Uh oh!

yostashiro Jan 5, 2023

Uh oh!

yostashiro commented Jan 5, 2023

Uh oh!

yostashiro commented Jan 28, 2023

Uh oh!

yostashiro commented Jan 28, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

		@@ -0,0 +1 @@
		This module provides the price unit format of sale report depends on the choice of price_decimal_places in currency.

-This module provides the price unit format of sale report depends on the choice of price_decimal_places in currency.
+This module provides the option to adjust the price unit format (number of decimal places to apply)
+of sale reports according to the configuration of price_decimal_places in currency.
+This module depends on report_qweb_decimal_place module in OCA/reporting-engine.

Conversation

AungKoKoLin1997 commented Jan 4, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

yostashiro left a comment

Choose a reason for hiding this comment

Uh oh!

yostashiro Jan 5, 2023

Choose a reason for hiding this comment

Uh oh!

AungKoKoLin1997 commented Jan 5, 2023

Uh oh!

yostashiro commented Jan 5, 2023

Uh oh!

AungKoKoLin1997 commented Jan 5, 2023

Uh oh!

yostashiro Jan 5, 2023

Choose a reason for hiding this comment

Uh oh!

AungKoKoLin1997 Jan 5, 2023

Choose a reason for hiding this comment

Uh oh!

yostashiro Jan 5, 2023

Choose a reason for hiding this comment

Uh oh!

yostashiro commented Jan 5, 2023

Uh oh!

yostashiro commented Jan 28, 2023

Uh oh!

yostashiro commented Jan 28, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

AungKoKoLin1997 commented Jan 4, 2023 •

edited

Loading