Repository navigation
ci: stop passing TARGET into the build container - #150
Open
Bjordis Collaku (bjordiscollaku) wants to merge 1 commit into
Open
Bjordis Collaku (bjordiscollaku) wants to merge 1 commit into
Bjordis Collaku (bjordiscollaku) wants to merge 1 commit into
Conversation
The debian/rules targets were passed into the build container as TARGET. bindgen reads TARGET as a Cargo target triple whenever clang is given no explicit --target, so it ran clang with --target=binary and failed. make rustavailable therefore failed on every build, masked by the "|| true" in debian/rules.d/2-binary-arch.mk, and CONFIG_RUST_IS_AVAILABLE was left unset against a policy of y. Rename the variable to RULES_TARGETS. Nothing in debian/ or the kernel Makefile reads TARGET, and the targets handed to debian/rules are unchanged for every flavours value. Verified with the real prepare stage on Ubuntu 26.04 arm64 for qcom and qcom-rt: without TARGET exported, make rustavailable reports "Rust is available!", and the shipped .config differs from today's by exactly CONFIG_RUST_IS_AVAILABLE=y. CONFIG_RUST stays off per the qcom annotations, so no Rust code is built. Closes #144 Signed-off-by: Bjordis Collaku <bcollaku@qti.qualcomm.com>
Bjordis Collaku (bjordiscollaku)
marked this pull request as ready for review
October 9, 2026 18:37
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #144
build-kernel.ymlpassed thedebian/rulestargets into the build container asTARGET. bindgen readsTARGETas a Cargo target triple whenever clang has no explicit--target, so it ran clang with--target=binary.make rustavailablefailed on every build, hidden by the|| trueindebian/rules.d/2-binary-arch.mk, andCONFIG_RUST_IS_AVAILABLEwas left unset against a policy ofy.This renames the variable to
RULES_TARGETS.Effect on the kernel. The shipped
.configgains exactly one line forqcomandqcom-rt:CONFIG_RUST_IS_AVAILABLE=y.CONFIG_RUSTstays off per the qcom annotations, so no Rust code is built.Validation. Run with the real
preparestage on Ubuntu 26.04 arm64 for both flavours: withTARGET=binaryexported, clang reportsunknown target triple 'binary'; without it,make rustavailablereports "Rust is available!". The targets handed todebian/rulesare identical before and after for everyflavoursvalue, and nothing indebian/or the kernelMakefilereadsTARGET. The container script parses withbash -n, and actionlint and zizmor are unchanged from the base.CI build. run 37965472447, dispatched from this branch for
qcomandqcom-rtwith debug packages:make rustavailablereports "Rust is available!" for both flavours, with nounknown target triple, the first CI build with Rust available. All 13 packages built and uploaded.Stacked on #141.