Skip to content

build: use external ssh configs, update ca cert#13

Merged
infinitewarp merged 5 commits intomainfrom
fix-dist-git-ssh-20251030
Nov 13, 2025
Merged

build: use external ssh configs, update ca cert#13
infinitewarp merged 5 commits intomainfrom
fix-dist-git-ssh-20251030

Conversation

@infinitewarp
Copy link
Copy Markdown
Member

No description provided.

@infinitewarp infinitewarp changed the title build: update to support required bastion proxyjump build: update to use updated ssh configs and ca cert Nov 12, 2025
@infinitewarp infinitewarp changed the title build: update to use updated ssh configs and ca cert build: use external ssh configs, update ca cert Nov 12, 2025
@abellotti
Copy link
Copy Markdown
Contributor

PR looks good, tried it locally.

I think remaining issue is the message for suggested commands:

discovery-cli should exist at:

    /repos/discovery-cli

Create a scratch build:

    cd /repos/discovery-cli
    rhpkg build --release rhel-9 --target=discovery-1-rhel-9-candidate --scratch

Update the release branch and create the release build:

    cd /repos/discovery-cli
    git checkout discovery-1-rhel-9
    git rebase private-abellott-1762991837.929325
    git push
    rhpkg build --scratch
    rhpkg build

The discovery-1-rhel-9* references should be discovery-2-rhel-9*

Also, the rhpkg build --release rhel-9 --target=discovery-1-rhel-9-candidate --scratch fails with:

bash-5.2$ rhpkg build --release rhel-9 --target=discovery-1-rhel-9-candidate --scratch
usage: rhpkg [-h] [--config CONFIG] [--dry-run] [--release RELEASE] [--name NAME] [--namespace NAMESPACE] [--user USER] [--password PASSWORD]
             [--runas RUNAS] [--path PATH] [--verbose] [--debug] [-q] [--released] [--unreleased] [--offline]
             {help,build,chain-build,clean,clog,clone,co,copr-build,commit,ci,compile,container-build,container-build-setup,diff,flatpak-build,gimmespec,gitbuildhash,gitcred,giturl,import,install,lint,list-side-tags,local,mockbuild,mock-config,module-build,module-scratch-build,module-build-cancel,module-build-info,module-build-local,module-build-watch,module-overview,new,new-sources,patch,pre-push-check,prep,pull,push,remote,remove-side-tag,request-side-tag,retire,scratch-build,sources,srpm,switch-branch,tag,unused-patches,upload,verify-files,verrel,brew-path,bugzilla,ci-submit-result,errata,maven-build,maven-chain,osh,covscan,publican-build,request-gated-side-tag,request-private-side-tag,set-gitlab-token,tests,wrapper-rpm,fork}
             ...
rhpkg: error: unrecognized arguments: --release rhel-9

@infinitewarp
Copy link
Copy Markdown
Member Author

Thanks for the test drive, @abellotti ! I went ahead and added some commits to this PR to fix those strings even though they were already issues before this PR's changes, and I updated the built-in branch filter to make the CLI show only discovery-2- branches by default. PTAL. 🙂

@infinitewarp infinitewarp merged commit acd0214 into main Nov 13, 2025
1 check passed
@infinitewarp infinitewarp deleted the fix-dist-git-ssh-20251030 branch November 13, 2025 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants