feat: convert services to new install script template #1276
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rackerchris
force-pushed
the
install-redis-sentinel
branch
2 times, most recently
from
aac274f to
ab1e4a9
Compare
rackerchris
force-pushed
the
install-redis-sentinel
branch
19 times, most recently
from
2e1f11a to
b852816
Compare
rackerchris
force-pushed
the
install-redis-sentinel
branch
2 times, most recently
from
99c59a7 to
6a814c7
Compare
Feature: Refactor Service Installation Scripts to Use Standard Template
This PR updates all services install/upgrade script to conform to the standard bash template.
Key Changes & Benefits:
Standardization: Adopts the robust, array-based command construction (helm_command) for safer execution and argument quoting.
Dynamic Values Loading: Switches to the standard loop logic for reliably including all .yaml files from both the base and custom override directories (/opt/genestack/base-helm-configs/redis-sentinel and /etc/genestack/helm-configs/redis-sentinel).
Improved Reliability: Ensures consistent extraction of the service chart version using the defined SERVICE_NAME variable.
GITHUB ACTIONS: Ensures that a github action exists for each service for pre-commit checking
This change reduces technical debt and makes the script easier to audit and maintain.
rackerchris
force-pushed
the
install-redis-sentinel
branch
from
b2bdd9b to
03aaa75
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature:Refactor Service Installation Scripts to Use Standard Template
This PR updates all services install/upgrade script to conform to the standard bash template.
Key Changes & Benefits:
helm_command) for safer execution and argument quoting..yamlfiles from both the base and custom override directories (/opt/genestack/base-helm-configs/redis-sentineland/etc/genestack/helm-configs/redis-sentinel).servicechart version using the definedSERVICE_NAMEvariable.This change reduces technical debt and makes the script easier to audit and maintain.