-
Notifications
You must be signed in to change notification settings - Fork 120
Removal of bicep-types submodule with migration to pnpm #11139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Removal of bicep-types submodule with migration to pnpm #11139
Conversation
Signed-off-by: Brooke Hamilton <[email protected]>
Signed-off-by: Brooke Hamilton <[email protected]>
Signed-off-by: Brooke Hamilton <[email protected]>
Signed-off-by: Brooke Hamilton <[email protected]>
Signed-off-by: Brooke Hamilton <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Removes the bicep-types git submodule and migrates the repo’s JS/TS dependency management (notably typespec/ and hack/bicep-types-radius/) from npm to pnpm, updating workflows, devcontainer setup, and developer docs accordingly.
Changes:
- Removed
bicep-typessubmodule wiring (bicep-types,.gitmodules) and submodule-related build checks. - Added pnpm lockfiles and updated build/generation scripts to use pnpm.
- Updated GitHub workflows, devcontainer bootstrap, and contributor docs (including a migration guide).
Reviewed changes
Copilot reviewed 23 out of 29 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| typespec/pnpm-lock.yaml | Adds pnpm lockfile for TypeSpec tooling. |
| typespec/package-lock.json | Removes npm lockfile in favor of pnpm. |
| hack/bicep-types-radius/src/generator/pnpm-lock.yaml | Adds pnpm lockfile for the generator package. |
| hack/bicep-types-radius/src/generator/package.json | Switches bicep-types source to a git dependency and adds postinstall build/link logic. |
| hack/bicep-types-radius/src/generator/.npmrc | Configures pnpm behavior for the generator package. |
| hack/bicep-types-radius/src/autorest.bicep/package.json | Switches bicep-types source to a git dependency and adds postinstall build/link logic. |
| hack/bicep-types-radius/src/autorest.bicep/.npmrc | Configures pnpm behavior for the autorest extension package. |
| docs/contributing/contributing-code/contributing-code-prerequisites/README.md | Updates codegen prerequisites from npm to pnpm commands. |
| docs/contributing/contributing-code/contributing-code-building/README.md | Removes submodule-related build note. |
| docs/contributing/bicep-types-migration-guide.md | Adds migration steps for existing clones. |
| build/test.mk | Updates oav installation guidance to pnpm. |
| build/generate.mk | Updates generator prerequisites and bicep-types generation flow to pnpm. |
| build/build.mk | Removes submodule existence/version checks from make build. |
| bicep-types | Removes the submodule entry. |
| .gitmodules | Removes submodule configuration. |
| .github/workflows/validate-bicep.yaml | Removes submodule checkout and adds pnpm setup. |
| .github/workflows/publish-docs.yaml | Removes submodule checkout and migrates TypeSpec/autorest/oav installs to pnpm. |
| .github/workflows/long-running-azure.yaml | Removes submodule checkout. |
| .github/workflows/lint.yaml | Removes submodule checkout and migrates TypeSpec/autorest/oav installs to pnpm. |
| .github/workflows/functional-test-noncloud.yaml | Removes submodule checkout and adds pnpm setup. |
| .github/workflows/functional-test-cloud.yaml | Removes submodule checkout. |
| .github/workflows/codeql.yml | Removes submodule checkout and adds pnpm setup for JS analysis. |
| .github/workflows/build.yaml | Removes submodule checkout and adds pnpm setup before bicep-types generation. |
| .github/dependabot.yml | Replaces submodule updates with npm-ecosystem updates for the pnpm-managed projects. |
| .devcontainer/post-create.sh | Migrates devcontainer bootstrap steps to pnpm and adds pnpm configuration. |
| .devcontainer/devcontainer.json | Configures devcontainer Node feature to install pnpm v10. |
Files not reviewed (4)
- hack/bicep-types-radius/src/generator/package-lock.json: Language not supported
- hack/bicep-types-radius/src/generator/pnpm-lock.yaml: Language not supported
- typespec/package-lock.json: Language not supported
- typespec/pnpm-lock.yaml: Language not supported
Signed-off-by: Brooke Hamilton <[email protected]>
Signed-off-by: Brooke Hamilton <[email protected]>
Signed-off-by: Brooke Hamilton <[email protected]>
Co-authored-by: Copilot <[email protected]> Signed-off-by: Brooke Hamilton <[email protected]>
Signed-off-by: Brooke Hamilton <[email protected]>
Signed-off-by: Brooke Hamilton <[email protected]>
Signed-off-by: Brooke Hamilton <[email protected]>
DariuszPorowski
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just one suggestion for dev container
Co-authored-by: Dariusz Porowski <[email protected]> Signed-off-by: Brooke Hamilton <[email protected]>
Signed-off-by: Brooke Hamilton <[email protected]>
|
/run-tests |
1 similar comment
|
/run-tests |
|
/run-tests |
|
/ok-to-test |
Description
This PR removes the
bicep-typesgit submodule and migrates JavaScript/TypeScript package management from npm to pnpm. Thebicep-typesdependency is now fetched as a git dependency and built via apostinstallscript, simplifying the developer experience.Key changes:
bicep-typesgit submodule and.gitmodulesfilepackage-lock.json) to pnpm (pnpm-lock.yaml) for:typespec/hack/bicep-types-radius/src/generator/hack/bicep-types-radius/src/autorest.bicep/Type of change
Testing
docs/contributing/bicep-types-migration-guide.md.Contributor checklist
Please verify that the PR meets the following requirements, where applicable:
Related PRs: