-
Notifications
You must be signed in to change notification settings - Fork 120
Removal of bicep-types submodule with migration to pnpm #11139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
brooke-hamilton
wants to merge
14
commits into
radius-project:main
Choose a base branch
from
brooke-hamilton:brooke-hamilton/remove-bicep-types-submodule-1
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
6ebb0c9
remove submodule
brooke-hamilton c3fa927
rename migration guide
brooke-hamilton 4556bc8
lint
brooke-hamilton 7ee518c
make format
brooke-hamilton ec110bc
dev container pnpm updates
brooke-hamilton 14c62d9
dev container post-create
brooke-hamilton 9767b74
dev container code review feedback
brooke-hamilton 7bab094
tsp not global
brooke-hamilton badd799
code review
brooke-hamilton 9d7d3a4
code review comments
brooke-hamilton e39bb97
tsp not installed error message
brooke-hamilton e9c507e
migration guide update
brooke-hamilton 99486ca
Apply suggestion from @DariuszPorowski
brooke-hamilton 044b455
node version bump from 22 to 24 for current LTS
brooke-hamilton File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2,22 +2,51 @@ | |
|
|
||
| set -e | ||
|
|
||
| # Install TypeSpec first to ensure the language server is available when the VS Code extension loads. | ||
| npm install -g @typespec/compiler | ||
| echo "============================================================================" | ||
| echo "Starting post-create setup..." | ||
| echo "============================================================================" | ||
|
|
||
| # Set SHELL for pnpm setup (not always set in devcontainer post-create context) | ||
| echo "Setting SHELL environment variable..." | ||
| export SHELL="${SHELL:-/bin/bash}" | ||
|
|
||
| # Adding workspace as safe directory to avoid permission issues | ||
| echo "Adding workspace as git safe directory..." | ||
| git config --global --add safe.directory /workspaces/radius | ||
|
|
||
| # Configure pnpm global bin directory | ||
| echo "Configuring pnpm global bin directory..." | ||
| pnpm setup | ||
| export PNPM_HOME="$HOME/.local/share/pnpm" | ||
| export PATH="$PNPM_HOME:$PATH" | ||
|
|
||
| # Configure pnpm store directory inside the container to avoid hard-link issues | ||
| # with mounted workspace filesystem (hard links cannot cross filesystem boundaries) | ||
| echo "Configuring pnpm store directory..." | ||
| pnpm config set store-dir /tmp/.pnpm-store | ||
|
|
||
| # Prerequisites for Code Generation, see https://github.com/radius-project/radius/tree/main/docs/contributing/contributing-code/contributing-code-prerequisites#code-generation | ||
| echo "Setting up TypeSpec dependencies..." | ||
| (cd typespec && pnpm install) | ||
|
|
||
| echo "Installing autorest globally..." | ||
| pnpm add -g [email protected] --allow-build=autorest | ||
|
|
||
| echo "Installing oav globally..." | ||
| pnpm add -g [email protected] | ||
|
|
||
| # Install the binary form of golangci-lint, as recommended | ||
| # https://golangci-lint.run/welcome/install/#local-installation | ||
| echo "Installing golangci-lint v2.8.0..." | ||
| curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/HEAD/install.sh | sh -s -- -b "$(go env GOPATH)/bin" v2.8.0 | ||
|
|
||
| # Other go tools | ||
| echo "Installing controller-gen..." | ||
| go install sigs.k8s.io/controller-tools/cmd/[email protected] | ||
|
|
||
| echo "Installing mockgen..." | ||
| go install go.uber.org/mock/[email protected] | ||
|
|
||
| # Prerequisites for Code Generation, see https://github.com/radius-project/radius/tree/main/docs/contributing/contributing-code/contributing-code-prerequisites#code-generation | ||
| cd typespec || exit | ||
| npm ci | ||
| npm install -g [email protected] | ||
| npm install -g [email protected] | ||
| echo "============================================================================" | ||
| echo "Post-create setup completed successfully!" | ||
| echo "============================================================================" | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -55,7 +55,6 @@ jobs: | |
| - name: Checkout | ||
| uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8 # v6.0.1 | ||
| with: | ||
| submodules: recursive | ||
| persist-credentials: false | ||
|
|
||
| - name: Setup Go | ||
|
|
@@ -70,17 +69,22 @@ jobs: | |
| with: | ||
| node-version-file: .node-version | ||
|
|
||
| - name: Setup pnpm | ||
| uses: pnpm/action-setup@41ff72655975bd51cab0327fa583b6e92b6d3061 # v4.2.0 | ||
| with: | ||
| version: 10 | ||
|
|
||
| - name: Install TypeSpec compiler | ||
| run: | | ||
| pushd typespec | ||
| npm ci | ||
| pnpm install --frozen-lockfile | ||
| popd | ||
|
|
||
| - name: Install autorest | ||
| run: npm install -g [email protected] | ||
| run: pnpm add -g [email protected] --allow-build=autorest | ||
|
|
||
| - name: Install oav | ||
| run: npm install -g [email protected] | ||
| run: pnpm add -g [email protected] | ||
|
|
||
| - name: Install mockgen | ||
| run: go install go.uber.org/mock/[email protected] | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -49,7 +49,6 @@ jobs: | |
| with: | ||
| repository: radius-project/radius | ||
| path: radius | ||
| submodules: recursive | ||
| persist-credentials: false | ||
|
|
||
| - name: Setup Python | ||
|
|
@@ -89,17 +88,22 @@ jobs: | |
| with: | ||
| node-version-file: radius/.node-version | ||
|
|
||
| - name: Setup pnpm | ||
| uses: pnpm/action-setup@41ff72655975bd51cab0327fa583b6e92b6d3061 # v4.2.0 | ||
| with: | ||
| version: 10 | ||
|
|
||
| - name: Install TypeSpec compiler | ||
| run: | | ||
| pushd radius/typespec | ||
| npm ci | ||
| pnpm install --frozen-lockfile | ||
| popd | ||
|
|
||
| - name: Install autorest | ||
| run: npm install -g [email protected] | ||
| run: pnpm add -g [email protected] --allow-build=autorest | ||
|
|
||
| - name: Install oav | ||
| run: npm install -g [email protected] | ||
| run: pnpm add -g [email protected] | ||
|
|
||
| - name: Install mockgen | ||
| run: | | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1 @@ | ||
| 22 | ||
| 24 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Submodule bicep-types
deleted from
556bf5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.