Tiny fix imbalance env var change

[fzyzcjy]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello @fzyzcjy, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a minor configuration adjustment by explicitly disabling a specific memory imbalance check within the SGLANG runtime environment. This change is intended to fine-tune the behavior or address a particular operational scenario related to tensor parallelism memory management.

Highlights

• SGLANG Environment Variable Configuration: A new environment variable, "SGLANG_ENABLE_TP_MEMORY_INBALANCE_CHECK", has been added to the SGLANG configuration within the init_rollout_engines function and set to "false".

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces a new environment variable SGLANG_ENABLE_TP_MEMORY_INBALANCE_CHECK to disable the TP memory imbalance check. My review suggests removing a redundant, older environment variable to improve code clarity and maintainability.

[gemini-code-assist]

The environment variable SGLANG_DISABLE_TP_MEMORY_INBALANCE_CHECK appears to be redundant with the newly added SGLANG_ENABLE_TP_MEMORY_INBALANCE_CHECK. Setting the DISABLE variable to "true" has the same effect as setting the ENABLE variable to "false". To improve clarity and maintainability, it would be better to remove the older DISABLE version and only keep the new one.

Suggested change

	"SGLANG_DISABLE_TP_MEMORY_INBALANCE_CHECK": "true",
	"SGLANG_ENABLE_TP_MEMORY_INBALANCE_CHECK": "false",
	"SGLANG_ENABLE_TP_MEMORY_INBALANCE_CHECK": "false",