Skip to content

Tiny fix imbalance env var change #537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fzyzcjy wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Tiny fix imbalance env var change #537

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions miles/ray/rollout.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -509,6 +509,7 @@ def init_rollout_engines(args, pg, all_rollout_engines):
"SGLANG_JIT_DEEPGEMM_PRECOMPILE": "false",
"SGL_DISABLE_TP_MEMORY_INBALANCE_CHECK": "true",
"SGLANG_DISABLE_TP_MEMORY_INBALANCE_CHECK": "true",
"SGLANG_ENABLE_TP_MEMORY_INBALANCE_CHECK": "false",
Comment on lines 511 to +512
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Jan 31, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The environment variable SGLANG_DISABLE_TP_MEMORY_INBALANCE_CHECK appears to be redundant with the newly added SGLANG_ENABLE_TP_MEMORY_INBALANCE_CHECK. Setting the DISABLE variable to "true" has the same effect as setting the ENABLE variable to "false". To improve clarity and maintainability, it would be better to remove the older DISABLE version and only keep the new one.

Suggested change
"SGLANG_DISABLE_TP_MEMORY_INBALANCE_CHECK": "true",
"SGLANG_ENABLE_TP_MEMORY_INBALANCE_CHECK": "false",
"SGLANG_ENABLE_TP_MEMORY_INBALANCE_CHECK": "false",

"SGLANG_MEMORY_SAVER_CUDA_GRAPH": "true",
"SGLANG_BATCH_INVARIANT_OPS_ENABLE_MM_FALLBACK_VARIANT": "true",
"SGLANG_ENABLE_HEALTH_ENDPOINT_GENERATION": "false",
Expand Down