Skip to content

RC: Account address separation #1420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
May 12, 2025
Merged

RC: Account address separation #1420

merged 10 commits into from
May 12, 2025

Conversation

cmilesb
Copy link
Contributor

@cmilesb cmilesb commented Apr 15, 2025

Depends on #1341 and #1327.
DOC-4886

Releasing May?

@cmilesb cmilesb added do not merge yet rc Redis Cloud docs labels Apr 15, 2025
@cmilesb cmilesb requested review from yharesh and a team April 15, 2025 19:48
@cmilesb cmilesb self-assigned this Apr 15, 2025
Copy link
Collaborator

@mich-elle-luna mich-elle-luna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! just one typo in the changelog description

@cmilesb cmilesb requested a review from a team April 23, 2025 21:59
Copy link
Contributor

@andy-stark-redis andy-stark-redis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only one very minor suggestion (feel free to ignore it), but otherwise LGTM.

Base automatically changed from DOC-5042 to main April 28, 2025 14:03
@yharesh
Copy link

yharesh commented May 11, 2025

The only thing i see is that on the Add credit card flow, we need to make it clear that the business address can also be added from "add credit card" page and in case business address already exist and the user wants apply it to asccoiate his business address with the new added card he can simply check the "Same as business address" checkbox.
Other than that, all looks great!

@cmilesb cmilesb merged commit bee6235 into main May 12, 2025
5 checks passed
@cmilesb cmilesb deleted the DOC-4886 branch May 12, 2025 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do not merge yet rc Redis Cloud docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants