Allow images to be built on the fly. #40
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EmmaLRussell
reviewed
Dec 4, 2025
|
|
||
| @dataclass | ||
| class BuildSpec: | ||
| path: str |
Contributor
There was a problem hiding this comment.
Suggested change
| path: str | |
| # Path to Dockerfile | |
| path: str |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #40 +/- ##
==========================================
+ Coverage 97.33% 97.41% +0.08%
==========================================
Files 16 16
Lines 1686 1704 +18
Branches 102 102
==========================================
+ Hits 1641 1660 +19
Misses 35 35
+ Partials 10 9 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
Done. It's actually a BuildSpec or ImageReference. |
If a `BuildSpec` is passed as the image parameter to a container, constellation will build the image using that specification before starting the container. The image is built unconditionally. However thanks to Docker's build cache nothing happens on repeated build.
EmmaLRussell
approved these changes
Dec 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a
BuildSpecis passed as the image parameter to a container, constellation will build the image using that specification before starting the container.The image is built unconditionally. However thanks to Docker's build cache nothing happens on repeated build.