Add missing CSRs #1236
Add missing CSRs #1236
Conversation
|
It appears that That leaves Looks like to get these new CSRs to pass the CI tests, we'll need to add the fields.
[FYI, I removed "ustatus, uie, utvec, uscratch, uepc, ucause, utval, uip, sedeleg, sideleg" from the PR description.] |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1236 +/- ##
=======================================
Coverage 46.05% 46.05%
=======================================
Files 11 11
Lines 4942 4942
Branches 1345 1345
=======================================
Hits 2276 2276
Misses 2666 2666
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ThinkOpenly
left a comment
ThinkOpenly
left a comment
There was a problem hiding this comment.
Yay! CI passed!
Just a few nits, then we'll get this merged.
|
@cmd05, will you be able to address the comments in this PR soon? |
|
@ThinkOpenly I had addressed the comments for the PR. Is there any update regarding it? |
ThinkOpenly
left a comment
ThinkOpenly
left a comment
There was a problem hiding this comment.
Let's add some more info to sie. The aliases are needed, but there are already aliases from mie back to sie, which I don't think should be there. We should probably remove the sie aliases from mie.yaml. We should probably remove all of the aliases from mie.yaml, to my understanding.
| address: 0x104 | ||
| priv_mode: S | ||
| definedBy: S | ||
| length: XLEN |
There was a problem hiding this comment.
...
sieis the corresponding SXLEN-bit read/write register...
| length: XLEN | |
| length: SXLEN |
| location: 5 | ||
| description: | | ||
| Supervisor Timer Interrupt Enable | ||
| type: RO-H |
There was a problem hiding this comment.
| type: RO-H | |
| type: RW |
| location: 9 | ||
| description: | | ||
| Supervisor External Interrupt Enable | ||
| type: RO-H |
There was a problem hiding this comment.
| type: RO-H | |
| type: RW |
| location: 13 | ||
| description: | | ||
| Local Counter Overflow Interrupt Enable | ||
| type: RW-H |
There was a problem hiding this comment.
| type: RW-H | |
| type: RW |
| writable: true | ||
| fields: | ||
| SSIE: | ||
| location: 1 |
There was a problem hiding this comment.
| location: 1 | |
| location: 1 | |
| alias: mie.SSIE |
| type: RW | ||
| reset_value: UNDEFINED_LEGAL | ||
| STIE: | ||
| location: 5 |
There was a problem hiding this comment.
| location: 5 | |
| location: 5 | |
| alias: mie.STIE |
| type: RO-H | ||
| reset_value: UNDEFINED_LEGAL | ||
| SEIE: | ||
| location: 9 |
There was a problem hiding this comment.
| location: 9 | |
| location: 9 | |
| alias: mie.SEIE |
| type: RO-H | ||
| reset_value: UNDEFINED_LEGAL | ||
| LCOFIE: | ||
| location: 13 |
There was a problem hiding this comment.
| location: 13 | |
| location: 13 | |
| alias: mie.LCOFIE |
2 participants
Adds basic information for missing CSRs necessary for #1209. List of CSRs: sie, dscratch0, dscratch1
Based on: