Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clarify behavior of invalid SDICN #79

Merged
merged 2 commits into from
Oct 1, 2024
Merged

Conversation

ved-rivos
Copy link
Collaborator

closes #59

chapter7.adoc Outdated
@@ -124,13 +124,16 @@ When `SDICN` is not the number of an implemented interrupt controller, or is
zero then the following rules apply to all privilege modes:

* The S-level external interrupt pending signal indicated in `mip.SEIP` is 0.
* All `siselect` values that access IMSIC registers are reserved.
* All non-custom values of `siselect` designate an _inaccessible_ register. When
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this correct when there are users of Sscsrind other than AIA?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should have been a bit more precise. "All non-custom values that access IMSIC registers"

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated.

Copy link
Collaborator

@rsahita rsahita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rsahita rsahita merged commit 00f5b97 into riscv:main Oct 1, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Question about siselect when SDICN is zero
3 participants