fix(core): fix passing incorrect actor input to create

[NathanFlurry]

No description provided.

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Preview	Comments	Updated (UTC)
rivetkit-serverless	Error			Sep 26, 2025 0:15am

[claude]

Claude finished @NathanFlurry's task —— View job

---

Code Review for PR #1300

Reviewing the pull request "fix(core): fix passing incorrect actor input to create"

Todo List

• Read repository guidelines (CLAUDE.md)
• Examine the changed file and understand the fix
• Analyze git diff to see exact changes
• Review code for quality, bugs, performance, and security
• Check test coverage considerations
• Provide comprehensive feedback

---

Review Summary

This PR fixes a critical bug in packages/rivetkit/src/remote-manager-driver/mod.ts:142 where the wrong variable was being used when encoding actor input.

The Fix

Before:

input: input ? cbor.encode(actorInput).toString("base64") : undefined,

After:

input: actorInput
    ? cbor.encode(actorInput).toString("base64")
    : undefined,

Analysis

✅ Code Quality & Best Practices

• Correct Variable Usage: The fix properly uses actorInput instead of the undefined input variable in the getOrCreateWithKey method
• Consistent Formatting: The change follows the codebase's formatting standards by splitting the ternary operator across multiple lines
• Pattern Consistency: This now matches the same pattern used in the createActor method at line 178

✅ Bug Fix Assessment

• Critical Logic Error: The original code was checking for the existence of input (which doesn't exist in this scope) but then encoding actorInput
• Variable Scope: In getOrCreateWithKey, the destructured parameter is input: actorInput (line 130), so the condition should check actorInput
• Runtime Impact: This bug would have caused the input to always be undefined regardless of whether actorInput was provided, breaking actor initialization

✅ Security Considerations

• No security concerns introduced
• The fix maintains the same CBOR encoding and base64 conversion process
• Input validation and encoding remain unchanged

✅ Performance Considerations

• No performance impact - same encoding logic, just using the correct variable
• Actually improves performance by properly checking the variable before encoding

⚠️ Test Coverage Recommendations

While this is a straightforward bug fix, consider adding tests to verify:

1. Integration Test: Ensure getOrCreateWithKey properly passes actor input to the created actor
2. Unit Test: Verify that when actorInput is provided, it gets properly CBOR encoded and base64 converted
3. Edge Case Test: Confirm behavior when actorInput is undefined or null

The bug would have been caught by tests that verify actor initialization with input data.

Verdict

✅ LGTM - This is a clean, necessary bug fix that:

• Resolves a critical logic error
• Maintains code consistency
• Has no negative side effects
• Follows existing patterns in the codebase

The PR title accurately describes the fix, and the change is minimal and focused.

---

[NathanFlurry]

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

• chore(example): update chat example #1301 : 2 dependent PRs (#1299 , #1302 )
• fix(core): fix passing incorrect actor input to create #1300 👈 (View in Graphite)
• fix(inspector): allow connection to inspector when using engine driver #1269
• main

---

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

• merge queue - adds this PR to the back of the merge queue
• hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

[pkg-pr-new]

More templates

• example-ai-agent
• example-better-auth-external-db
• chat-room
• example-cloudflare-workers
• example-cloudflare-workers-hono
• counter
• example-crdt
• example-database
• example-sqlite
• example-elysia
• example-express
• example-game
• example-hono
• example-hono-react
• example-next-js
• example-rate
• example-raw-fetch-handler
• example-raw-websocket-handler-proxy
• example-react
• starter
• example-stream
• example-sync
• example-tenant
• example-trpc

@rivetkit/actor

pnpm add https://pkg.pr.new/rivet-dev/rivetkit/@rivetkit/actor@1300

@rivetkit/cloudflare-workers

pnpm add https://pkg.pr.new/rivet-dev/rivetkit/@rivetkit/cloudflare-workers@1300

@rivetkit/core

pnpm add https://pkg.pr.new/rivet-dev/rivetkit/@rivetkit/core@1300

@rivetkit/db

pnpm add https://pkg.pr.new/rivet-dev/rivetkit/@rivetkit/db@1300

@rivetkit/framework-base

pnpm add https://pkg.pr.new/rivet-dev/rivetkit/@rivetkit/framework-base@1300

@rivetkit/next-js

pnpm add https://pkg.pr.new/rivet-dev/rivetkit/@rivetkit/next-js@1300

@rivetkit/react

pnpm add https://pkg.pr.new/rivet-dev/rivetkit/@rivetkit/react@1300

rivetkit

pnpm add https://pkg.pr.new/rivet-dev/rivetkit@1300

@rivetkit/sql-loader

pnpm add https://pkg.pr.new/rivet-dev/rivetkit/@rivetkit/sql-loader@1300

commit: 9a11e38

[claude]

Claude finished @NathanFlurry's task —— View job

---

Code Review for PR #1300

Reviewing the pull request "fix(core): fix passing incorrect actor input to create"

Todo List

• Read repository guidelines (CLAUDE.md)
• Examine the changed file and understand the fix
• Analyze git diff to see exact changes
• Review code for quality, bugs, performance, and security
• Check test coverage considerations
• Provide comprehensive feedback

---

Review Summary

This PR fixes a critical bug in packages/rivetkit/src/remote-manager-driver/mod.ts:142 where the wrong variable was being used when encoding actor input.

The Fix

Before:

input: input ? cbor.encode(actorInput).toString("base64") : undefined,

After:

input: actorInput
    ? cbor.encode(actorInput).toString("base64")
    : undefined,

Analysis

✅ Code Quality & Best Practices

• Correct Variable Usage: The fix properly uses actorInput instead of the undefined input variable in the getOrCreateWithKey method
• Consistent Formatting: The change follows the codebase's formatting standards by splitting the ternary operator across multiple lines
• Pattern Consistency: This now matches the same pattern used in the createActor method at line 178

✅ Bug Fix Assessment

• Critical Logic Error: The original code was checking for the existence of input (which doesn't exist in this scope) but then encoding actorInput
• Variable Scope: In getOrCreateWithKey, the destructured parameter is input: actorInput (line 130), so the condition should check actorInput
• Runtime Impact: This bug would have caused the input to always be undefined regardless of whether actorInput was provided, breaking actor initialization

✅ Security Considerations

• No security concerns introduced
• The fix maintains the same CBOR encoding and base64 conversion process
• Input validation and encoding remain unchanged

✅ Performance Considerations

• No performance impact - same encoding logic, just using the correct variable
• Actually improves performance by properly checking the variable before encoding

⚠️ Test Coverage Recommendations

While this is a straightforward bug fix, consider adding tests to verify:

1. Integration Test: Ensure getOrCreateWithKey properly passes actor input to the created actor
2. Unit Test: Verify that when actorInput is provided, it gets properly CBOR encoded and base64 converted
3. Edge Case Test: Confirm behavior when actorInput is undefined or null

The bug would have been caught by tests that verify actor initialization with input data.

Verdict

✅ LGTM - This is a clean, necessary bug fix that:

• Resolves a critical logic error
• Maintains code consistency
• Has no negative side effects
• Follows existing patterns in the codebase

The PR title accurately describes the fix, and the change is minimal and focused.

---

[claude]

Claude finished @NathanFlurry's task —— View job

---

Code Review for PR #1300

Reviewing the pull request "fix(core): fix passing incorrect actor input to create"

Todo List

• Read repository guidelines (CLAUDE.md)
• Examine the changed file and understand the fix
• Analyze git diff to see exact changes
• Review code for quality, bugs, performance, and security
• Check test coverage considerations
• Provide comprehensive feedback

---

Review Summary

This PR fixes a critical bug in packages/rivetkit/src/remote-manager-driver/mod.ts:142 where the wrong variable was being used when encoding actor input.

The Fix

Before:

input: input ? cbor.encode(actorInput).toString("base64") : undefined,

After:

input: actorInput
    ? cbor.encode(actorInput).toString("base64")
    : undefined,

Analysis

✅ Code Quality & Best Practices

• Correct Variable Usage: The fix properly uses actorInput instead of the undefined input variable in the getOrCreateWithKey method
• Consistent Formatting: The change follows the codebase's formatting standards by splitting the ternary operator across multiple lines
• Pattern Consistency: This now matches the same pattern used in the createActor method at line 178

✅ Bug Fix Assessment

• Critical Logic Error: The original code was checking for the existence of input (which doesn't exist in this scope) but then encoding actorInput
• Variable Scope: In getOrCreateWithKey, the destructured parameter is input: actorInput (line 130), so the condition should check actorInput
• Runtime Impact: This bug would have caused the input to always be undefined regardless of whether actorInput was provided, breaking actor initialization

✅ Security Considerations

• No security concerns introduced
• The fix maintains the same CBOR encoding and base64 conversion process
• Input validation and encoding remain unchanged

✅ Performance Considerations

• No performance impact - same encoding logic, just using the correct variable
• Actually improves performance by properly checking the variable before encoding

⚠️ Test Coverage Recommendations

While this is a straightforward bug fix, consider adding tests to verify:

1. Integration Test: Ensure getOrCreateWithKey properly passes actor input to the created actor
2. Unit Test: Verify that when actorInput is provided, it gets properly CBOR encoded and base64 converted
3. Edge Case Test: Confirm behavior when actorInput is undefined or null

The bug would have been caught by tests that verify actor initialization with input data.

Verdict

✅ LGTM - This is a clean, necessary bug fix that:

• Resolves a critical logic error
• Maintains code consistency
• Has no negative side effects
• Follows existing patterns in the codebase

The PR title accurately describes the fix, and the change is minimal and focused.

---

[claude]

Claude finished @NathanFlurry's task —— View job

---

Code Review for PR #1300

Reviewing the pull request "fix(core): fix passing incorrect actor input to create"

Todo List

• Read repository guidelines (CLAUDE.md)
• Examine the changed file and understand the fix
• Analyze git diff to see exact changes
• Review code for quality, bugs, performance, and security
• Check test coverage considerations
• Provide comprehensive feedback

---

Review Summary

This PR fixes a critical bug in packages/rivetkit/src/remote-manager-driver/mod.ts:142 where the wrong variable was being used when encoding actor input.

The Fix

Before:

input: input ? cbor.encode(actorInput).toString("base64") : undefined,

After:

input: actorInput
    ? cbor.encode(actorInput).toString("base64")
    : undefined,

Analysis

✅ Code Quality & Best Practices

• Correct Variable Usage: The fix properly uses actorInput instead of the undefined input variable in the getOrCreateWithKey method
• Consistent Formatting: The change follows the codebase's formatting standards by splitting the ternary operator across multiple lines
• Pattern Consistency: This now matches the same pattern used in the createActor method at line 178

✅ Bug Fix Assessment

• Critical Logic Error: The original code was checking for the existence of input (which doesn't exist in this scope) but then encoding actorInput
• Variable Scope: In getOrCreateWithKey, the destructured parameter is input: actorInput (line 130), so the condition should check actorInput
• Runtime Impact: This bug would have caused the input to always be undefined regardless of whether actorInput was provided, breaking actor initialization

✅ Security Considerations

• No security concerns introduced
• The fix maintains the same CBOR encoding and base64 conversion process
• Input validation and encoding remain unchanged

✅ Performance Considerations

• No performance impact - same encoding logic, just using the correct variable
• Actually improves performance by properly checking the variable before encoding

⚠️ Test Coverage Recommendations

While this is a straightforward bug fix, consider adding tests to verify:

1. Integration Test: Ensure getOrCreateWithKey properly passes actor input to the created actor
2. Unit Test: Verify that when actorInput is provided, it gets properly CBOR encoded and base64 converted
3. Edge Case Test: Confirm behavior when actorInput is undefined or null

The bug would have been caught by tests that verify actor initialization with input data.

Verdict

✅ LGTM - This is a clean, necessary bug fix that:

• Resolves a critical logic error
• Maintains code consistency
• Has no negative side effects
• Follows existing patterns in the codebase

The PR title accurately describes the fix, and the change is minimal and focused.

---

[claude]

Claude finished @NathanFlurry's task —— View job

---

Code Review for PR #1300

Reviewing the pull request "fix(core): fix passing incorrect actor input to create"

Todo List

• Read repository guidelines (CLAUDE.md)
• Examine the changed file and understand the fix
• Analyze git diff to see exact changes
• Review code for quality, bugs, performance, and security
• Check test coverage considerations
• Provide comprehensive feedback

---

Review Summary

This PR fixes a critical bug in packages/rivetkit/src/remote-manager-driver/mod.ts:142 where the wrong variable was being used when encoding actor input.

The Fix

Before:

input: input ? cbor.encode(actorInput).toString("base64") : undefined,

After:

input: actorInput
    ? cbor.encode(actorInput).toString("base64")
    : undefined,

Analysis

✅ Code Quality & Best Practices

• Correct Variable Usage: The fix properly uses actorInput instead of the undefined input variable in the getOrCreateWithKey method
• Consistent Formatting: The change follows the codebase's formatting standards by splitting the ternary operator across multiple lines
• Pattern Consistency: This now matches the same pattern used in the createActor method at line 178

✅ Bug Fix Assessment

• Critical Logic Error: The original code was checking for the existence of input (which doesn't exist in this scope) but then encoding actorInput
• Variable Scope: In getOrCreateWithKey, the destructured parameter is input: actorInput (line 130), so the condition should check actorInput
• Runtime Impact: This bug would have caused the input to always be undefined regardless of whether actorInput was provided, breaking actor initialization

✅ Security Considerations

• No security concerns introduced
• The fix maintains the same CBOR encoding and base64 conversion process
• Input validation and encoding remain unchanged

✅ Performance Considerations

• No performance impact - same encoding logic, just using the correct variable
• Actually improves performance by properly checking the variable before encoding

⚠️ Test Coverage Recommendations

While this is a straightforward bug fix, consider adding tests to verify:

1. Integration Test: Ensure getOrCreateWithKey properly passes actor input to the created actor
2. Unit Test: Verify that when actorInput is provided, it gets properly CBOR encoded and base64 converted
3. Edge Case Test: Confirm behavior when actorInput is undefined or null

The bug would have been caught by tests that verify actor initialization with input data.

Verdict

✅ LGTM - This is a clean, necessary bug fix that:

• Resolves a critical logic error
• Maintains code consistency
• Has no negative side effects
• Follows existing patterns in the codebase

The PR title accurately describes the fix, and the change is minimal and focused.

---

[graphite-app]

Merge activity

• Sep 25, 11:36 PM UTC: NathanFlurry added this pull request to the Graphite merge queue.
• Sep 25, 11:36 PM UTC: CI is running for this pull request on a draft pull request (#1307) due to your merge queue CI optimization settings.
• Sep 25, 11:37 PM UTC: Merged by the Graphite merge queue via draft PR: #1307.