Multi-account 1/4: verified account identity, cards, and naming - #1147
Closed
robinebers wants to merge 24 commits into
Closed
Multi-account 1/4: verified account identity, cards, and naming#1147robinebers wants to merge 24 commits into
robinebers wants to merge 24 commits into
Conversation
- ClaudeConfigDirDiscovery: bounded dot-dir/.config scan; identity-extraction-is-validation, credential shape (file or attributes-only keychain probe), token-free support trail - ProviderAccountAssembly: folds same-account dirs onto the default card as extra log roots, mints records+cards for distinct accounts; bare family id now reserved for default-home holders - ClaudeAuthStore: .configDir scope (own keychain item + credentials file only; no Desktop/env fallback); default card drops unpinned Desktop fallback while extra cards exist - ClaudeProvider/ProviderCatalog: injectable Provider identity, per-card descriptor ids, scoped scanner roots with partitioned parse cache - Layout: account cards seed their family's default metric set (translatedForAccountCards); unknown saved layout state is retained as invisible tombstones so an absent card's customization returns with it Co-authored-by: Cursor <cursoragent@cursor.com>
…seeding/tombstones Co-authored-by: Cursor <cursoragent@cursor.com>
robinebers
added
the
gate-passed
Cursor
robinebers
changed the title
robinebers
marked this pull request as ready for review
August 24, 2026 12:29
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
…he account registry The account registry (ProviderAccountsStore) is now @observable and shared between the launch pass and the UI, so a rename (customLabel) re-titles the card everywhere without a relaunch. "Rename…" lives in the card's right-click menu (alert with a text field; empty clears back to the derived name) and as a Name field at the top of the card's Customize detail. Share cards render outside the environment, so the live name is passed in explicitly. Co-authored-by: Cursor <cursoragent@cursor.com>
Renames never bake into the launch Provider anymore — Provider.displayName only ever carries the derived default, and everything human-facing resolves the live name through the account registry at render time: Total Spend slices carry a caller-resolved title (legend + share export), menu bar VoiceOver text, notification titles, and the CLI/HTTP API resolve at their boundaries. Co-authored-by: Cursor <cursoragent@cursor.com>
robinebers
marked this pull request as draft
August 24, 2026 13:26
robinebers
changed the title
robinebers
marked this pull request as ready for review
August 24, 2026 13:57
robinebers
marked this pull request as draft
August 24, 2026 17:10
robinebers
marked this pull request as ready for review
August 24, 2026 18:33
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit bcbd0c9. Configure here.
Owner
Author
|
Closing in favor of a single, minimal Claude organization-based replacement. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
Discover multiple Claude CLI accounts and give each account a stable, isolated card.
What was happening
What this changes
Tests
Screenshots
Note
High Risk
Touches Claude OAuth/credential selection, keychain scoping, and per-card identity verification—security-sensitive paths where mis-routing could show the wrong account’s usage.
Overview
Adds multi-account Claude support: launch-time discovery of extra CLI logins in custom config dirs, each mapped to its own provider card (
claude@…) with scoped credentials, usage logs, and identity checks so one account cannot borrow another’s Desktop login, env token, or spend history.Introduces an observable account registry (
ProviderAccountsStorev2) with derived titles, user renames (customLabel), and live display-name resolution across the dashboard, menu bar, notifications, share cards, local HTTP API, and CLI—cached snapshots keep baked derived names; human-facing output re-resolves at read time.Layout and ordering adapt for account cards: default metrics seed per extra card, absent cards persist as tombstones until the login returns, and new account ids slot next to their family on the dashboard. Telemetry normalizes account card ids back to provider families. CI also runs on
codex/account-*branches.Reviewed by Cursor Bugbot for commit 3932758. Bugbot is set up for automated code reviews on this repo. Configure here.