Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Foundation work for one-step debugger in Workflows #761

Merged
merged 45 commits into from
Nov 13, 2024
Merged

Foundation work for one-step debugger in Workflows #761

merged 45 commits into from
Nov 13, 2024

Conversation

PawelPeczek-Roboflow
Copy link
Collaborator

@PawelPeczek-Roboflow PawelPeczek-Roboflow commented Oct 30, 2024 •
edited
Loading

Description

In this PR we are introducing the following capabilities into EE:

  • decoupling data serialisation and deserialisation from core of EE in favour of kind-based extensions
  • ability to define batch-oriented inputs for any kind and any input dimensionality

Which effectively would allow us to enable debugger experience for Workflows ecosystem

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

How has this change been tested, please provide a testcase or example of how you tested the change?

  • bunch of new tests in CI for all changes introduced
  • old CI still 🟢

Any specific deployment considerations

For example, documentation changes, usability, usage/costs, secrets, etc.

Docs

  • Docs updated? What were the changes:

@PawelPeczek-Roboflow PawelPeczek-Roboflow marked this pull request as ready for review October 31, 2024 16:07
@PawelPeczek-Roboflow
Copy link
Collaborator Author

@hansent @grzegorz-roboflow - I need to have this reviewed

grzegorz-roboflow
grzegorz-roboflow requested changes Nov 13, 2024
View reviewed changes
docs/workflows/execution_engine_changelog.md Outdated Show resolved Hide resolved
docs/workflows/execution_engine_changelog.md Outdated Show resolved Hide resolved
docs/workflows/execution_engine_changelog.md Outdated Show resolved Hide resolved
docs/workflows/workflows_compiler.md Outdated Show resolved Hide resolved
docs/workflows/workflows_compiler.md Outdated Show resolved Hide resolved
inference/core/workflows/core_steps/common/serializers.py Outdated Show resolved Hide resolved
inference/core/workflows/core_steps/common/serializers.py Outdated Show resolved Hide resolved
inference/core/workflows/core_steps/loader.py Show resolved Hide resolved
inference/core/workflows/core_steps/loader.py Show resolved Hide resolved
inference/core/workflows/core_steps/loader.py Show resolved Hide resolved
hansent
hansent previously approved these changes Nov 13, 2024
View reviewed changes
@PawelPeczek-Roboflow
Copy link
Collaborator Author

CI fails on BC in aiohttp that affects tests - there was a namedtuple changed in a breaking way - should not affect old inference releases

@PawelPeczek-Roboflow PawelPeczek-Roboflow merged commit f202755 into main Nov 13, 2024
71 checks passed
@PawelPeczek-Roboflow PawelPeczek-Roboflow deleted the feature/add_support_for_all_kinds_inputs branch November 13, 2024 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grzegorz-roboflow grzegorz-roboflow grzegorz-roboflow approved these changes

@yeldarby yeldarby Awaiting requested review from yeldarby yeldarby is a code owner

@probicheaux probicheaux Awaiting requested review from probicheaux probicheaux is a code owner

@capjamesg capjamesg Awaiting requested review from capjamesg capjamesg is a code owner

@hansent hansent Awaiting requested review from hansent hansent is a code owner

Assignees
No one assigned
Labels
release 0.27.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PawelPeczek-Roboflow @hansent @grzegorz-roboflow