-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Foundation work for one-step debugger in Workflows #761
Merged
PawelPeczek-Roboflow
merged 45 commits into
main
from
feature/add_support_for_all_kinds_inputs
Nov 13, 2024
Merged
Changes from 26 commits
Commits
Show all changes
45 commits
Select commit
Hold shift + click to select a range
9661b48
WIP - first changes to add serializers and deserializers
PawelPeczek-Roboflow 38fc7e5
Create first scratch of implementation for serializers and deserializers
PawelPeczek-Roboflow 209866e
WIP - added handling for arbitrary dimensions in inputs
PawelPeczek-Roboflow 297177f
Finish basic testing of the new feature
PawelPeczek-Roboflow d31a3d2
Fix batch vs non-batch oriented parameters
PawelPeczek-Roboflow ff227d5
Add additional tests
PawelPeczek-Roboflow 3379902
Add remaining tests
PawelPeczek-Roboflow 329b2cc
Apply refactor to add BatchOfDataSelector
PawelPeczek-Roboflow 0a6fff4
WIP - add more tests
PawelPeczek-Roboflow e150394
Resolve conflicts with main
PawelPeczek-Roboflow 2c5a13a
Add deserialization for more kinds to ensure ability to properly vali…
PawelPeczek-Roboflow 598dff2
Merge branch 'main' into feature/add_support_for_all_kinds_inputs
PawelPeczek-Roboflow 7bdcce8
Add tests for deserialization
PawelPeczek-Roboflow 34773e3
Add tests for filtering of workflow results
PawelPeczek-Roboflow f58a6d1
Add documentation - part 1
PawelPeczek-Roboflow aba0aaf
Add docs - part 2
PawelPeczek-Roboflow 51d5e6f
Adjust docs to changes
PawelPeczek-Roboflow 272e7ef
Add extension to inference_sdk to handle nested batches of input para…
PawelPeczek-Roboflow 52ddb9f
Add changes to align batches and scalars regarding their place in eco…
PawelPeczek-Roboflow b02502d
Start using scalar selector everywhere
PawelPeczek-Roboflow 533dd4f
Start using BatchSelector for input images everywhere
PawelPeczek-Roboflow 5b5ec6c
Update docs and add more tests
PawelPeczek-Roboflow 08f2027
Fix block assembler
PawelPeczek-Roboflow 9f31fe3
Merge branch 'main' into feature/add_support_for_all_kinds_inputs
PawelPeczek-Roboflow 9d11498
Merge branch 'main' into feature/add_support_for_all_kinds_inputs
PawelPeczek-Roboflow e14a960
Refactor the PR to use Selector(...) type annotation for manifest sel…
PawelPeczek-Roboflow c2c08c1
WIP
PawelPeczek-Roboflow 75ce9a4
WIP
PawelPeczek-Roboflow 0d859a9
Add abstraction to mark mixed inputs
PawelPeczek-Roboflow 9a35585
Fix docs
PawelPeczek-Roboflow a17c656
Adjust docs to changes
PawelPeczek-Roboflow 5cf9bf9
Resolve conflicts with main
PawelPeczek-Roboflow 2dff5de
Make linters happy
PawelPeczek-Roboflow 89a0aef
Fix bug with Florence block and align blocks expected EE version
PawelPeczek-Roboflow 6f3ca50
Fix typo in docs
PawelPeczek-Roboflow a42fb71
Fix issue with docs generation
PawelPeczek-Roboflow c9a3753
Merge branch 'main' into feature/add_support_for_all_kinds_inputs
hansent d3bed3a
Merge branch 'main' into feature/add_support_for_all_kinds_inputs
grzegorz-roboflow 1c2e494
Update docs/workflows/execution_engine_changelog.md
hansent 9b9ff3c
Update docs/workflows/execution_engine_changelog.md
hansent e897103
Update docs/workflows/workflows_compiler.md
hansent 21cd0a6
Update docs/workflows/workflows_compiler.md
hansent 5beeb04
Apply suggestions from PR CR
PawelPeczek-Roboflow 6992db4
Merge branch 'main' into feature/add_support_for_all_kinds_inputs
PawelPeczek-Roboflow 647fd28
Merge branch 'main' into feature/add_support_for_all_kinds_inputs
PawelPeczek-Roboflow File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This feels like a really powerful and extensible pattern. Wondering if it also opens the door for e.g. kind conversion/casting via serialize as one kind and deserialize as other
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes as an opportunity to hook up this extension
no if you ask if this is possible without any changes to the PR
and probably no - if the question is broader - the polymorphism in kinds type system - that would need to be approached from different angle