-
Notifications
You must be signed in to change notification settings - Fork 1.4k
CI: test minimal builds #20311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
pcanal
wants to merge
6
commits into
root-project:master
Choose a base branch
from
pcanal:test-minimal
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
CI: test minimal builds #20311
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
c32dbee
CI: test minimal builds
pcanal 54aa443
build_utils.py: proper backslash escaping
pcanal 66d7e4f
NFC casing in buildconfig/global.txt
pcanal 18edda2
CI: For minimal build, do not use global settings
pcanal 93d1080
CI/NFC: trim trailing spaces
pcanal 41d01fe
CI/minimal use property flag
pcanal File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 changes: 3 additions & 0 deletions
3
.github/workflows/root-ci-config/buildconfig/alma10-minimal.txt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| builtin_vdt=ON | ||
| builtin_zlib=ON | ||
| builtin_zstd=ON |
80 changes: 80 additions & 0 deletions
80
.github/workflows/root-ci-config/buildconfig/global-minimal.txt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,80 @@ | ||
| alien=OFF | ||
| all=OFF | ||
| arrow=OFF | ||
| asan=OFF | ||
| asserts=OFF | ||
| builtin_cfitsio=OFF | ||
| builtin_clang=ON | ||
| builtin_cling=ON | ||
| builtin_cppzmq=ON | ||
| builtin_davix=OFF | ||
| builtin_fftw3=OFF | ||
| builtin_freetype=OFF | ||
| builtin_ftgl=OFF | ||
| builtin_gl2ps=OFF | ||
| builtin_glew=OFF | ||
| builtin_gsl=OFF | ||
| builtin_llvm=ON | ||
| builtin_lz4=OFF | ||
| builtin_lzma=OFF | ||
| builtin_nlohmannjson=OFF | ||
| builtin_openssl=OFF | ||
| builtin_openui5=ON | ||
| builtin_pcre=OFF | ||
| builtin_tbb=OFF | ||
| builtin_unuran=OFF | ||
| builtin_vc=OFF | ||
| builtin_vdt=OFF | ||
| builtin_veccore=OFF | ||
| builtin_xrootd=OFF | ||
| builtin_xxhash=OFF | ||
| builtin_zeromq=ON | ||
| builtin_zlib=OFF | ||
| builtin_zstd=OFF | ||
| ccache=ON | ||
| cefweb=OFF | ||
| check_connection=OFF | ||
| clingtest=OFF | ||
| cocoa=OFF | ||
| coverage=OFF | ||
| cuda=OFF | ||
| daos=OFF | ||
| dcache=OFF | ||
| dev=OFF | ||
| distcc=OFF | ||
| fail-on-missing=ON | ||
| fcgi=OFF | ||
| gminimal=OFF | ||
| gnuinstall=OFF | ||
| gsl_shared=OFF | ||
| gviz=OFF | ||
| jemalloc=OFF | ||
| libcxx=OFF | ||
| macos_native=OFF | ||
| memory_termination=OFF | ||
| minimal=ON | ||
| mpi=OFF | ||
| pythia8=OFF | ||
| qt6web=OFF | ||
| r=OFF | ||
| rootbench=OFF | ||
| roottest=ON | ||
| runtime_cxxmodules=ON | ||
| shadowpw=OFF | ||
| shared=ON | ||
| soversion=OFF | ||
| tcmalloc=OFF | ||
| testing=ON | ||
| tmva-gpu=OFF | ||
| tmva-cudnn=OFF | ||
| tmva-pymva=OFF | ||
| tmva-rmva=OFF | ||
| tmva-sofie=OFF | ||
| unfold=ON | ||
| unuran=ON | ||
| uring=OFF | ||
| vc=OFF | ||
| veccore=OFF | ||
| vecgeom=OFF | ||
| win_broken_tests=OFF | ||
| winrtdebug=OFF | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just as curiosity, why isn't the config just
minimal=ON, without specifying any other build option?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is a good question. In this first approximation, I assumed there was a 'good' reason why those were explicitly off in the usual
global.txtand keep all the setting that wereOFFor were auxiliary but I may hare erred.One other reason is that we wanted the options to be explicit rather than implicit and thus for the build to not depend on a change in the source code for the default to change. In the case of
minimalthis might actually be a detriment.