Skip to content

Conversation

@christophfroehlich
Copy link
Contributor

@christophfroehlich christophfroehlich commented Oct 20, 2025

The test cases are independent of the implementation, and all implementations should succeed with the tests.

I haven't touched the testcases itself, only moved it to a header file which is installed as INTERFACE library if BUILD_TESTING is true.
Maybe we should install it always, so that the header file is shipped with binaries from the buildfarm and users of custom plugins could use it?

set explicit size for reference output methods
  error: cannot bind non-const lvalue reference of type
@mergify
Copy link

mergify bot commented Oct 21, 2025

This pull request is in conflict. Could you fix it @christophfroehlich?

@mergify
Copy link

mergify bot commented Oct 21, 2025

This pull request is in conflict. Could you fix it @christophfroehlich?

@mergify
Copy link

mergify bot commented Oct 22, 2025

This pull request is in conflict. Could you fix it @christophfroehlich?

Base automatically changed from refactor/tests to master November 19, 2025 20:39
@mergify
Copy link

mergify bot commented Nov 19, 2025

This pull request is in conflict. Could you fix it @christophfroehlich?

@christophfroehlich christophfroehlich marked this pull request as ready for review November 19, 2025 21:04
@christophfroehlich christophfroehlich added backport-jazzy Triggers PR backport to ROS 2 jazzy. check-prerelease-downstream Runs the pre-release workflow with 1st level downstream dependencies labels Nov 19, 2025
@codecov
Copy link

codecov bot commented Nov 19, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.62%. Comparing base (7a77940) to head (b5a1e93).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #211      +/-   ##
==========================================
- Coverage   88.11%   87.62%   -0.49%     
==========================================
  Files           4        5       +1     
  Lines         303      291      -12     
  Branches       53       53              
==========================================
- Hits          267      255      -12     
  Misses         21       21              
  Partials       15       15              
Flag Coverage Δ
unittests 87.62% <100.00%> (-0.49%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...terface/test/kinematics_interface_common_tests.hpp 100.00% <100.00%> (ø)
...terface_kdl/test/test_kinematics_interface_kdl.cpp 100.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-jazzy Triggers PR backport to ROS 2 jazzy. check-prerelease-downstream Runs the pre-release workflow with 1st level downstream dependencies

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants