-
Notifications
You must be signed in to change notification settings - Fork 19
Add a test template for plugin implementations #211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Co-authored-by: Sai Kishor Kothakota <[email protected]>
Co-authored-by: Sai Kishor Kothakota <[email protected]>
Co-authored-by: Sai Kishor Kothakota <[email protected]>
Co-authored-by: Sai Kishor Kothakota <[email protected]>
set explicit size for reference output methods error: cannot bind non-const lvalue reference of type
|
This pull request is in conflict. Could you fix it @christophfroehlich? |
8e21779 to
7a9ce64
Compare
|
This pull request is in conflict. Could you fix it @christophfroehlich? |
|
This pull request is in conflict. Could you fix it @christophfroehlich? |
|
This pull request is in conflict. Could you fix it @christophfroehlich? |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #211 +/- ##
==========================================
- Coverage 88.11% 87.62% -0.49%
==========================================
Files 4 5 +1
Lines 303 291 -12
Branches 53 53
==========================================
- Hits 267 255 -12
Misses 21 21
Partials 15 15
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
The test cases are independent of the implementation, and all implementations should succeed with the tests.
I haven't touched the testcases itself, only moved it to a header file which is installed as INTERFACE library if BUILD_TESTING is true.
Maybe we should install it always, so that the header file is shipped with binaries from the buildfarm and users of custom plugins could use it?